Repository navigation
Change keyboard shortcut for strike-through #2134
Description
Describe the bug
On my Mac in Firefox, I open a markdown file or create a new one, highlight any text so that the floating popup toolbar with Add Link and Link File pops up, and press COMMAND+SHIFT+X, the entire interface becomes flush right and all symbols are mirrored. Pressing COMMAND+SHIFT+X reverse the action to normal. When I close the file, and open it again, I have to highlight any text first so that COMMAND+SHIFT+X causes this unexpected behavior.
To Reproduce with a new text file
- Create a
New text document.md - Open the document
- Write any text in the document for example
abc - Highlight
abc - Now, keep text highlighted or click on any white space
- Press COMMAND+SHIFT+X
- Interface becomes flush right and all symbols are mirrored
- Press COMMAND+SHIFT+X again and interface goes back to normal
- Only causes this unexpected behavior when file is freshly opened and any text is highlighted for the first time
To Reproduce with an existing text file
- Open an existing Markdown file
- Highlight any text
- Now, keep text highlighted or click on any white space
- Press COMMAND+SHIFT+X
- Interface becomes flush right and all symbols are mirrored
- Press COMMAND+SHIFT+X again and interface goes back to normal
- Only causes this unexpected behavior when file is freshly opened and any text is highlighted for the first time
Expected behavior
Nothing would happen after pressing COMMAND+SHIFT+X
Screenshots
Initial state
Highlighting text
After pressing COMMAND+SHIFT+X (see also Sidebar content, which flipped as well)
Client details:
- OS: macOS Monterey 12.1
- Browser: Firefox 96.0.2 (64-bit)
- MacBookAir (M1, 2020)
Reacted by Brent Gervais
Activity
max-nextcloud commentedon Feb 13, 2022
COMMAND+SHIFT+X is the keyboard shortcut for right to left languages (Hebrew, Arabic, ...) in firefox. It also works in this text entry for this comment - so nothing text specific.
Which behavior would you have expected from this shortcut?
Closing this issue as the behavior is desired the way it is (unless people more familiar with rtl languages can specify how it would be done better). If you were looking for some specific functionality and lack a keyboard shortcut for it please let us know what you were missing the shortcut for.
pat-githubber commentedon Feb 13, 2022
Sorry, it’s a nooby knowledge gap 😅
juliusknorr commentedon Feb 14, 2022
@max-nextcloud Maybe we should consider changing the strikethrough shortcut then, as that would be the suggestion to the user for tiptap 2 #1981 (comment)
max-nextcloud commentedon Feb 14, 2022
Good catch. I'd say we go without a keyboard shortcut... or maybe ctrl+alt+S as the icon has an S in it and ctrl+S is save and ctrl+shif+S is "save as" in a lot of programms and screenshot in ff
juliusknorr commentedon Feb 14, 2022
Lets reopen that then to address this.
Ctrl+Alt-S sounds reasonable
Found https://defkey.com/search?irq=strikethrough which I find quite a useful collections but seems there is no common pattern at least for strikethrough
max-nextcloud commentedon Feb 17, 2022
reported upstream in ueberdosis/tiptap#2540
[-]Unexpected behavior after highlighting text and pressing COMMAND+SHIFT+X[/-][+]Change keyboard shortcut for strike-through[/+]juliusknorr commentedon Nov 3, 2023
Was fixed upstream and added with #4710