Skip to content

feat: allow admin delegation for System monitoring page - #1187

Open
whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:feat/admin-delegation-system-page
Open

whoalin1 wants to merge 1 commit into
nextcloud:masterfrom
whoalin1:feat/admin-delegation-system-page

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Closes #497

The System monitoring page is read-only but required full admin. Implement IDelegatedSettings on AdminSettings (same approach as logreader) so admins can grant the page via Settings → Administration → Delegation without handing out full admin.

getAuthorizedAppConfig() is empty because this UI does not write appconfig.

Test plan

  • As admin: Settings → Administration → Delegation lists System / Monitoring
  • Delegate to a group; member of that group (non-admin) can open the System page
  • Non-delegated users still cannot open it
  • Page still loads for full admins

AI disclosure

This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.

All commits carry an Assisted-by: Cursor:grok-4.7 trailer.

@whoalin1
whoalin1 force-pushed the feat/admin-delegation-system-page branch from 97cecc1 to eae8721 Compare October 9, 2026 14:10
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Assisted-by: Cursor:grok-4.7
Signed-off-by: whoalin1 <whoalin414@gmail.com>
@karlitschek
karlitschek force-pushed the feat/admin-delegation-system-page branch from eae8721 to d3c637f Compare October 23, 2026 09:29
@whoalin1

Copy link
Copy Markdown
Contributor Author

Note on the failing check-ai-trailers check: it's not a code/lint/test issue — the workflow correctly detected the Assisted-by: Cursor:grok-4.7 trailer on the commit (disclosing AI-assisted authorship, as intended) but then failed with 403 Resource not accessible by integration when it tried to create/apply the corresponding label. That looks like a GITHUB_TOKEN permissions limitation for workflows triggered by a fork PR, not something fixable from this branch. All other checks (DCO, lint, static analysis, test matrix) are green.

@kesselb

kesselb commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

The change allows a user with delegation permission to see the monitoring / system page. Showing the actual data does not work, because that change does not adjust the controller's to allow access for users with delegation permission.

image

@kesselb kesselb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controller needs update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin delegation should be possible for system monitoring (page) "systeminfo"

2 participants