Skip to content

[stable35] fix(dav): handle 4-byte text consistently in calendar indexes - #65488

Merged
susnux merged 2 commits into
stable35from
backport/65467/stable35
Nov 5, 2026
Merged

susnux merged 2 commits into
stable35from
backport/65467/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 14, 2026

Copy link
Copy Markdown

Backport of PR #65467

CalDAV indexes selected property values and parameters in the same table. However, updateProperties() used opposite supports4ByteText() checks for those two paths. Looks like #36528 may have inadvertently changed this conditional. Additional historical context in #5004.

Also remove the redundant pre-truncation in the ordinary-property path.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Add regression coverage for emoji in indexed ATTENDEE and ORGANIZER CN parameters. Assert that indexed values preserve four-byte characters when supported by the database and replace them when unsupported.

Assisted-by: Copilot:gpt-6-luna

Signed-off-by: Josh <josh.t.richards@gmail.com>
@backportbot backportbot Bot added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals feature: database Database related DB AI assisted ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient. labels Oct 14, 2026
@backportbot backportbot Bot added this to the Nextcloud 35.0.2 milestone Oct 14, 2026
@susnux
susnux merged commit d84cc8d into stable35 Nov 5, 2026
221 of 229 checks passed
@susnux
susnux deleted the backport/65467/stable35 branch November 5, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug feature: caldav Related to CalDAV internals feature: database Database related DB ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants