[SystemKeeper]

Summary

• Follow-up to fix: delete user credentials stored in storages_credentials when user gets deleted #45355

When deleting a user, we already call $avatarManager->deleteUserAvatar($this->uid);, which removes the avatars after the user was deleted. Additionally we had a before listener, which removed the avatars before a user was actually deleted. This (alongside the removal of credentials) is tricky when the userbackend denies the user deletion (e.g. LDAP with an active user).

How to test:

• Have a LDAP user with a custom avatar
• Run occ user:delete <ldap-user>
• See The specified user could not be deleted. Please check the logs.
• Check the avatar of the user -> it is gone.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[SystemKeeper]

/backport to stable35

[SystemKeeper]

/backport to stable34

[backportbot]

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/65435/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick fe1be727

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/65435/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[github-actions]

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com