Skip to content

[stable35] fix(mail): embed image logo only when using useTemplate - #65428

Merged
CarlSchwan merged 1 commit into
stable35from
backport/65422/stable35
Oct 19, 2026
Merged

CarlSchwan merged 1 commit into
stable35from
backport/65422/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Backport of #65422

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

The reason for this is that the change that introduced the embedded logo
broke the logo for all apps that did not call useTemplate.

This change uses the logo url by default and replaces it with cid:logo
only when the image is actually attached to the mail.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5
@salmart-dev
salmart-dev force-pushed the backport/65422/stable35 branch from 66ebf8e to 04ce0a1 Compare October 12, 2026 15:36
@salmart-dev
salmart-dev marked this pull request as ready for review October 12, 2026 15:46
@salmart-dev
salmart-dev requested a review from a team as a code owner October 12, 2026 15:46
@salmart-dev
salmart-dev requested review from provokateurin and sorbaugh and removed request for a team October 12, 2026 15:46
@CarlSchwan
CarlSchwan merged commit 42f996a into stable35 Oct 19, 2026
173 of 175 checks passed
@CarlSchwan
CarlSchwan deleted the backport/65422/stable35 branch October 19, 2026 12:58
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants