Skip to content

fix(external-share): move ExternalShareScanJob creation deeper - #64021

Merged
ArtificialOwl merged 1 commit into
masterfrom
fix/noid/move-external-share-scan-deeper
Nov 2, 2026
Merged

ArtificialOwl merged 1 commit into
masterfrom
fix/noid/move-external-share-scan-deeper

Conversation

@ArtificialOwl

Copy link
Copy Markdown
Member

This move the creation of the background job ExternalShareScanJob - implemented with #61908 - deeper/closer to the Share Acceptance action.
The reason for this change is that some path to reach the share acceptance (ie. auto-accept on trusted server) would not trigger the background job, therefor not scan the freshly created mountpoint.

@ArtificialOwl ArtificialOwl added this to the Nextcloud 36 milestone Sep 4, 2026
@ArtificialOwl
ArtificialOwl requested a review from a team as a code owner September 4, 2026 12:34
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Sep 4, 2026
@ArtificialOwl
ArtificialOwl requested review from Altahrim, CarlSchwan, provokateurin and sorbaugh and removed request for a team September 4, 2026 12:34
@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable35

@ArtificialOwl
ArtificialOwl marked this pull request as draft September 4, 2026 12:34
@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable34

@ArtificialOwl

Copy link
Copy Markdown
Member Author

/backport to stable33

@ArtificialOwl ArtificialOwl added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 4, 2026
@ArtificialOwl
ArtificialOwl force-pushed the fix/noid/move-external-share-scan-deeper branch 2 times, most recently from 82f050a to 5c7f571 Compare September 4, 2026 18:33
@ArtificialOwl
ArtificialOwl marked this pull request as ready for review September 6, 2026 12:15
@ArtificialOwl ArtificialOwl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 6, 2026
@ArtificialOwl
ArtificialOwl force-pushed the fix/noid/move-external-share-scan-deeper branch from 5c7f571 to ba66afb Compare October 6, 2026 12:46
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwl force-pushed the fix/noid/move-external-share-scan-deeper branch from ba66afb to 23b2a44 Compare November 2, 2026 15:50
@ArtificialOwl
ArtificialOwl requested a review from a team as a code owner November 2, 2026 15:50
@ArtificialOwl
ArtificialOwl requested review from icewind1991, leftybournes and salmart-dev and removed request for a team November 2, 2026 15:50
@ArtificialOwl
ArtificialOwl merged commit 0d635f0 into master Nov 2, 2026
307 of 315 checks passed
@ArtificialOwl
ArtificialOwl deleted the fix/noid/move-external-share-scan-deeper branch November 2, 2026 18:07
@backportbot

backportbot Bot commented Nov 2, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/64021/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23b2a448

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64021/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Nov 2, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/64021/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23b2a448

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64021/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants