Repository navigation
fix(external-share): move ExternalShareScanJob creation deeper - #64021
Merged
Merged
Conversation
ArtificialOwl
requested review from
Altahrim,
CarlSchwan,
provokateurin and
sorbaugh
and removed request for
a team
September 4, 2026 12:34
Member
Author
|
/backport to stable35 |
ArtificialOwl
marked this pull request as draft
September 4, 2026 12:34
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
ArtificialOwl
force-pushed
the
fix/noid/move-external-share-scan-deeper
branch
2 times, most recently
from
September 4, 2026 18:33
82f050a to
5c7f571
Compare
ArtificialOwl
marked this pull request as ready for review
September 6, 2026 12:15
provokateurin
approved these changes
Sep 7, 2026
ArtificialOwl
force-pushed
the
fix/noid/move-external-share-scan-deeper
branch
from
October 6, 2026 12:46
5c7f571 to
ba66afb
Compare
cristianscheid
approved these changes
Oct 28, 2026
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/move-external-share-scan-deeper
branch
from
November 2, 2026 15:50
ba66afb to
23b2a44
Compare
ArtificialOwl
requested review from
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
November 2, 2026 15:50
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/64021/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23b2a448
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64021/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/64021/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 23b2a448
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/64021/stable34Error: Failed to check for changes with origin/stable34: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
3 tasks
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This move the creation of the background job
ExternalShareScanJob- implemented with #61908 - deeper/closer to the Share Acceptance action.The reason for this change is that some path to reach the share acceptance (ie. auto-accept on trusted server) would not trigger the background job, therefor not scan the freshly created mountpoint.