Skip to content

fix: Store login name and not uid in session when login with webauthn - #63442

Merged
provokateurin merged 1 commit into
masterfrom
fix/fix-webauthn-loginname
Aug 25, 2026
Merged

provokateurin merged 1 commit into
masterfrom
fix/fix-webauthn-loginname

Conversation

@come-nc

@come-nc come-nc commented Aug 20, 2026 •

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

At login, the login name used is kept in session for some usecases later on.
When using WebAuthn, the controller was passing the uid instead of the login name to the rest of the login chain, resulting in wrong information in the session.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc self-assigned this Aug 20, 2026
@come-nc come-nc added the 2. developing Work in progress label Aug 20, 2026
@artonge
artonge force-pushed the fix/fix-webauthn-loginname branch from 091c5e1 to 8641db4 Compare August 20, 2026 15:13
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
@come-nc
come-nc force-pushed the fix/fix-webauthn-loginname branch from 8641db4 to 2171c86 Compare August 24, 2026 13:10
@come-nc
come-nc marked this pull request as ready for review August 24, 2026 13:10
@come-nc
come-nc requested a review from a team as a code owner August 24, 2026 13:10
@come-nc
come-nc requested review from Altahrim, icewind1991, provokateurin and sorbaugh and removed request for a team August 24, 2026 13:10
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 24, 2026
@come-nc
come-nc requested a review from artonge August 24, 2026 13:10
@provokateurin
provokateurin merged commit 3b2e743 into master Aug 25, 2026
207 of 215 checks passed
@provokateurin
provokateurin deleted the fix/fix-webauthn-loginname branch August 25, 2026 08:14
@skjnldsv skjnldsv mentioned this pull request Aug 25, 2026
@come-nc come-nc added this to the Nextcloud 35 milestone Oct 15, 2026
@come-nc

come-nc commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@backportbot

backportbot Bot commented Oct 15, 2026

Copy link
Copy Markdown

The backport to stable34 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34
git pull origin stable34

# Create the new backport branch
git checkout -b backport/63442/stable34

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2171c862

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63442/stable34

Error: Failed to check for changes with origin/stable34: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants