Repository navigation
use pdo for postgres setup - #381
Merged
Merged
Conversation
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bartv2, @DeepDiver1975 and @Faldon to be potential reviewers |
Member
|
| return $userIDs; | ||
| } | ||
|
|
||
| public function getSystemConfig() { |
Member
There was a problem hiding this comment.
😰 why? just use the methods from above?
Member
Author
There was a problem hiding this comment.
The connectionfactory wants a systemconfig instance
Member
There was a problem hiding this comment.
Then mark @internal at least please
Member
Author
There was a problem hiding this comment.
It's not exposed in the public interface
Member
There was a problem hiding this comment.
mmmm Maybe we should change the connectionfactory at some point then.
MorrisJobke
added
2. developing
icewind1991
force-pushed
the
postgres-setup
branch
from
July 13, 2016 12:04
bab359d to
908d750
Compare
icewind1991
force-pushed
the
postgres-setup
branch
from
July 13, 2016 12:33
908d750 to
b288c67
Compare
Member
Author
|
Tests are all green now |
icewind1991
added
3. to review
Member
|
👍 |
1 similar comment
Member
|
👍 |
| $query = $connection->prepare("ALTER ROLE " . addslashes($this->dbUser) . " CREATEDB WITH PASSWORD " . addslashes($this->dbPassword)); | ||
| } else { | ||
| // create the user | ||
| $query = $connection->prepare("CREATE USER " . addslashes($this->dbUser) . " CREATEDB PASSWORD " . addslashes($this->dbPassword)); |
Member
There was a problem hiding this comment.
This broke the tests on my app:
Syntax error: 7 ERROR: syntax error at or near "zxngvsgscub2i9frs64ac9r43ivk6j"
LINE 1: CREATE USER oc_admin CREATEDB PASSWORD zxngvsgscub2i9frs64ac
The ' are missing, I will add them.
https://travis-ci.org/nextcloud/announcementcenter/jobs/145487372
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
…ster command (nextcloud#381) Do not remove ExApp docker volume by default, deprecate old option `keep-data`, add new `rm-data` to remove ExApp data. --------- Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need of having the pgsql extension installed by using pdo/doctrine during setup
Fixes #367