Nextcloud 13: User changes do not get displayed #9112

Activity

1. tflidd

   added

   feature: ldap

   on Apr 7, 2018
2. rullzer commented on Apr 10, 2018

   

   rullzer

   on Apr 10, 2018

   Member

   More actions

   @nextcloud/ldap
3. blizzz commented on Apr 10, 2018

   

   blizzz

   on Apr 10, 2018

   Member

   More actions

   There's a cache holding data for 10 minutes (by default). I guess that kicked in. I am not aware of any issues, and saw it also working as expected on a change on our instance just recently.
4. blizzz

   added

   needs info

   on Apr 10, 2018
5. kroerig commented on Apr 10, 2018

   

   kroerig

   on Apr 10, 2018

   Last edited by kroerig

   Author

   More actions

   I edited the user account about 4 days ago und NC still displays the old name in the contact search.
   But with the new email and the "talk to" button also shows the new name.
6. blizzz commented on Apr 10, 2018

   

   blizzz

   on Apr 10, 2018

   Member

   More actions

   @kroerig then, for some reasons, the local addressbook (where the contactsmenu get its data from) was not updated. Could you provide your Nextcoud log file?
7. blizzz

   added

   feature: contacts menu

   on Apr 10, 2018
8. kroerig commented on Apr 10, 2018

   

   kroerig

   on Apr 10, 2018

   Author

   More actions

   https://archiv.leibniz-remscheid.de/nextcloud.log.bz2 (9.2MB, uncompressed 400MB)
9. TomGem commented on Jun 18, 2018

   

   TomGem

   on Jun 18, 2018

   Last edited by TomGem

   More actions

   I'm having the same issue.
   'Contacts' on the upper right seems to use the table 'oc_cards', which does not get updated if LDAP values change. As marriage is quite common if there are a few thousand accounts, I often have to correct the 'carddata' BLOB in 'oc_cards' manually.

   'occ user:info username' on the other hand displays the correct values
10. TomGem commented on Jun 28, 2018

    

    TomGem

    on Jun 28, 2018

    Last edited by TomGem

    More actions

    Fyi @kroerig, for now you could update Nextcloud users manually.

    alias occ="sudo -u www-data php /var/www/html/occ"
    
    # read values
    occ user:setting USERNAME user_ldap displayName
    occ user:setting USERNAME settings email
    
    # write values
    occ user:setting USERNAME user_ldap displayName "Firstname Lastname"
    occ user:setting USERNAME settings email "user@host.org"

    I wrote a little script to get the current values with ldapsearch and set them with occ if needed.
    Does not work..
11. kroerig commented on Jul 3, 2018

    

    kroerig

    on Jul 3, 2018

    Author

    More actions

    I tried your commands

    occ user:setting USERNAME user_ldap displayName

    already shows the right value.
12. kroerig commented on Jul 4, 2018

    

    kroerig

    on Jul 4, 2018

    Author

    More actions

    Today I had the next user that had to be renamed. Same problem. Now I'm on NC 13.0.4.

    'Contacts' on the upper right seems to use the table 'oc_cards',

    I found the wrong values also in 'oc_cards_properties'. This one seems to be used for seaching of contacts.

    Can I clear both tables and have NC populate them again?
13. TomGem commented on Jul 6, 2018

    

    TomGem

    on Jul 6, 2018

    More actions

    You're right, oc_cards does not get updated when changing the displayName.

    I'd interested in a way to repopulate oc_cards from ldap too.
14. blizzz

    added a commit that references this issue on Oct 25, 2018

    only write when the displayname differs, but then announce it

    ...

    This issue will close once commit bbe4410 is merged into the 'master' branch.

    bbe4410
15. blizzz commented on Oct 25, 2018

    

    blizzz

    on Oct 25, 2018

    Member

    More actions

    fix in #12054, would be awesome if you could test it
16. kroerig commented on Oct 26, 2018

    

    kroerig

    on Oct 26, 2018

    Last edited by kroerig

    Author

    More actions

    I tested and for me it does not work.
    But I'm on 14.0.3 now.

    I changed LDAP:displayname and also tried LDAP:givenname and LDAP:sn
    NC displays the old values on the users settings page, too.

    Is it possible that NC does this changes in the backgroud via cron, too? The problem is that not all users log into NC regulary, but others search for them.
17. blizzz commented on Oct 26, 2018

    

    blizzz

    on Oct 26, 2018

    Member

    More actions

    @kroerig you would need to apply the patch, first.

    Is it possible that NC does this changes in the backgroud via cron, too? The problem is that not all users log into NC regulary, but others search for them.

    Yes, we switched to update user date from LDAP in a background job (unless the mode is still ajax), apart from first fetch and on logins.
18. kroerig commented on Oct 26, 2018

    

    kroerig

    on Oct 26, 2018

    Author

    More actions

    Howto?
19. blizzz commented on Oct 26, 2018

    

    blizzz

    on Oct 26, 2018

    Member

    More actions

    @kroerig

    1. Back up app/user_ldap/lib/User/User.php
    2. Download https://patch-diff.githubusercontent.com/raw/nextcloud/server/pull/12054.patch
    3. Remove everything after and including diff --git a/apps/user_ldap/tests/User/UserTest.php b/apps/user_ldap/tests/User/UserTest.php (it is a test file and those are not shipped with the releases)
    4. from you Nextcloud root folder execute: patch -p1 < 12054.patch
    5. done

    (In case of errors, copy to the backed up file back to its place)
20. kroerig commented on Oct 28, 2018

    

    kroerig

    on Oct 28, 2018

    Author

    More actions

    Remove everything **after and including** shure? That would mean an empty file
    That does not work.

    I only get patch: **** Only garbage was found in the patch input.
21. blizzz commented on Oct 29, 2018

    

    blizzz

    on Oct 29, 2018

    Member

    More actions

    @kroerig you were a bit overeager in trimming it down. Copy that into a file (I added a commit anyhow):

    From bbe44108b5661d0c3935fa76e27abbc433fd458e Mon Sep 17 00:00:00 2001
    From: Arthur Schiwon <blizzz@arthur-schiwon.de>
    Date: Thu, 25 Oct 2018 23:41:12 +0200
    Subject: [PATCH 1/2] only write when the displayname differs, but then
     announce it
    
    refs #5212 and fixes #9112
    
    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    ---
     apps/user_ldap/lib/User/User.php       | 11 +++++++++--
     apps/user_ldap/tests/User/UserTest.php | 25 +++++++++++++++++++++++++
     2 files changed, 34 insertions(+), 2 deletions(-)
    
    diff --git a/apps/user_ldap/lib/User/User.php b/apps/user_ldap/lib/User/User.php
    index 02764a72eca..4afc8032f73 100644
    --- a/apps/user_ldap/lib/User/User.php
    +++ b/apps/user_ldap/lib/User/User.php
    @@ -414,14 +414,21 @@ private function store($key, $value) {
     	 *
     	 * @param string $displayName
     	 * @param string $displayName2
    -	 * @returns string the effective display name
    +	 * @return string the effective display name
     	 */
     	public function composeAndStoreDisplayName($displayName, $displayName2 = '') {
     		$displayName2 = (string)$displayName2;
     		if($displayName2 !== '') {
     			$displayName .= ' (' . $displayName2 . ')';
     		}
    -		$this->store('displayName', $displayName);
    +		$oldName = $this->config->getUserValue($this->uid, 'user_ldap', 'displayName', '');
    +		if ($oldName !== $displayName) {
    +			$this->store('displayName', $displayName);
    +			$user = $this->userManager->get($this->getUsername());
    +			if ($user instanceof \OC\User\User) {
    +				$user->triggerChange('displayName', $displayName);
    +			}
    +		}
     		return $displayName;
     	}
     
    
    From 9adf5422a2b3f44018a99a0979cda3f6e297a253 Mon Sep 17 00:00:00 2001
    From: Arthur Schiwon <blizzz@arthur-schiwon.de>
    Date: Fri, 26 Oct 2018 17:38:42 +0200
    Subject: [PATCH 2/2] do not run into UniqueConstraintViolationException
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit
    
    … when an unmapped user logs in for the first time when background job
    mode is ajax and no memcache was configured.
    
    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    ---
     apps/user_ldap/lib/User/User.php | 8 +++++---
     1 file changed, 5 insertions(+), 3 deletions(-)
    
    diff --git a/apps/user_ldap/lib/User/User.php b/apps/user_ldap/lib/User/User.php
    index 4afc8032f73..f4be19a7ad5 100644
    --- a/apps/user_ldap/lib/User/User.php
    +++ b/apps/user_ldap/lib/User/User.php
    @@ -421,11 +421,13 @@ public function composeAndStoreDisplayName($displayName, $displayName2 = '') {
     		if($displayName2 !== '') {
     			$displayName .= ' (' . $displayName2 . ')';
     		}
    -		$oldName = $this->config->getUserValue($this->uid, 'user_ldap', 'displayName', '');
    -		if ($oldName !== $displayName) {
    +		$oldName = $this->config->getUserValue($this->uid, 'user_ldap', 'displayName', null);
    +		if ($oldName !== $displayName)  {
     			$this->store('displayName', $displayName);
     			$user = $this->userManager->get($this->getUsername());
    -			if ($user instanceof \OC\User\User) {
    +			if (!empty($oldName) && $user instanceof \OC\User\User) {
    +				// if it was empty, it would be a new record, not a change emitting the trigger could
    +				// potentially cause a UniqueConstraintViolationException, depending on some factors.
     				$user->triggerChange('displayName', $displayName);
     			}
     		}
    
22. kroerig commented on Oct 29, 2018

    

    kroerig

    on Oct 29, 2018

    Author

    More actions

    hm, seams that one of my tries work.
    patching file apps/user_ldap/lib/User/User.php Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch.

    Got a new marrige announcemet for this weekend. Will try then.
23. blizzz commented on Oct 29, 2018

    

    blizzz

    on Oct 29, 2018

    Member

    More actions

    @kroerig best, copy back the backup and apply the new patch. i fixed a corner case inbetween, that probably does not affect you, nevertheless better to have the current code :) and, thanks for testing! :)
24. rullzer

    closed this as completedin #12054on Oct 30, 2018
25. blizzz

    added 2 commits that reference this issue on Oct 30, 2018

    Backport of #12054 to stable14

    ...

    This issue will close once commit bdb8e37 is merged into the 'master' branch.

    bdb8e37

    Backport of #12054 to stable13

    ...

    This issue will close once commit 908e6be is merged into the 'master' branch.

    908e6be
26. MorrisJobke

    added this to the Nextcloud 15 milestone on Oct 30, 2018
27. kroerig commented on Nov 11, 2018

    

    kroerig

    on Nov 11, 2018

    Author

    More actions

    @blizzz
    The displayname was changed but email still shows the old value.
28. blizzz commented on Nov 13, 2018

    

    blizzz

    on Nov 13, 2018

    Member

    More actions

    @kroerig email address changes are already done via the core user object and it propagates changes.

    Best clue: from a previous state the email was the same as saved as user preference, but the addressbook contained a different value.