Don't deprecate IDBConnection::getDatabasePlatform #51175

Activity

1. pulsejet commented on Mar 1, 2025

   

   pulsejet

   on Mar 1, 2025

   MemberAuthor

   More actions

   There are also edge cases where mysql and maria have different behavior

   https://github.com/pulsejet/memories/blob/7c9ed8adba2ffaf99362db8fe5ffecc6d88a8088/lib/Service/Places.php#L444-L446
2. susnux commented on Mar 1, 2025

   

   susnux

   on Mar 1, 2025

   Contributor

   More actions

   IIRC its needed for Doctrine DBAL 4.0 support, ref: #46192

   cc @nickvergessen
3. susnux

   added

   0. Needs triagePending check for reproducibility or if it fits our roadmapPending check for reproducibility or if it fits our roadmap

   feature: databaseDatabase related DBDatabase related DB

   bug

   on Mar 1, 2025
4. nickvergessen commented on Mar 1, 2025

   

   nickvergessen

   on Mar 1, 2025

   Member

   More actions

   Yeah we can not keep them and we should not expose them.

   I'm using it a lot for debugging queries, can't see any obvious clean alternative

   Upstreaming? It sounds roughly like https://github.com/nextcloud/server/blob/master/lib/private/DB/QueryBuilder/QueryBuilder.php#L160-L188 But I also sometimes miss getting an "executable query" back or logged.

   Also needed for cross platform truncate.

   Alternative: Upstream 😎

   There are also edge cases where mysql and maria have different behavior

   I'm fine with adding a parameter to getDatabaseProvider() or a second method, which returns different for MySQL and MariaDB. We can't change the default as that would break quite some other places. But we must make sure that only OCP constants are returned, so it doesn't break when updating doctrine.

   Side note: But the actual problem is that you use polygon database type which is not supported by all databases we support. Ref doctrine/dbal#2334
5. pulsejet commented on Mar 2, 2025

   

   pulsejet

   on Mar 2, 2025

   MemberAuthor

   More actions

   Noted, I'll make a migration plan then. Thanks for the prompt response!

   I'm fine with adding a parameter to getDatabaseProvider() or a second method, which returns different for MySQL and MariaDB.

   This will likely be needed first, I'll cook up something if possible.

   Thanks!
6. pulsejet

   closed this as not plannedon Mar 2, 2025
7. pulsejet

   added

   wontfixThis will not be worked onThis will not be worked on

   on Mar 2, 2025
8. pulsejet commented on Mar 2, 2025

   

   pulsejet

   on Mar 2, 2025

   MemberAuthor

   More actions

   But the actual problem is that you use polygon database type which is not supported by all databases we support

   Correct. It's not possible to do a real 2D lookup without some geometric type. Right now mysql / mariadb / postgres work fine (sqlite might work with some work, but doesn't seem worth the effort)
9. pulsejet

   added 3 commits that reference this issue on Aug 4, 2025

   feat(db): add method to test mariadb

   ...

   bd70470

   feat(db): add method to test mariadb

   ...

   cc79484

   feat(db): add method to test mariadb

   ...

   da2a567
10. nickvergessen

    added 2 commits that reference this issue on Aug 8, 2025

    feat(database): Add option to test for mariadb

    ...

    db5d934

    feat(database): Add option to test for mariadb

    ...

    5ecd3c4