Repository navigation
Improve change password dialogue #3565
Description
Recently, a user came to me saying that he couldn't change his password.
Only later I found out that he pressed the “change password” button before even typing, because to him the inputs looked disabled.
The biggest issue is probably that we don't have labels here. I stumbled upon this myself, entering two times the new password, not seeing that the first field requires the current password.
Suggestions for optimization:
- Add labels to the input fields.
- Create two input fields for the new password, to make sure you typed it correctly.
- Ask for the current password with a modal dialogue like in the App Store when installing an app.
current change password form on the »personal« page
I know it would be really great to have a pull-request from me, but I can't do it at the moment – maybe someone else feels that this is an issue, too, and has the resources to quickly fix it. 😊 😳
Reacted by Ben Schumacher, KB7777, Felix A. Epp, David Gleich and J0WI
Activity
nickvergessen commentedon Feb 22, 2017
Sounds good to me
mallory commentedon Mar 21, 2017
I just want to bump @floeschie's issue on the usability flaw in hiding the password reset link until after a failed attempt. The login page must have the password reset link visible at all times. This is expected behaviour. Without it, administrators like me are spending too much time helping our users gain access. Not to mention that it subtly reinforces to new users (which is most users) that this new platform is too hard for them. Thank you!
simison commentedon Jun 10, 2017
Heya @te-online and others! 👋
I feel like I could grab this as my first Nextcloud issue as I like to work both with code and design.
Looking at the code it looks like it would need a good overhaul, but I don't want to get too deep into it. I'm sure there are other more important issues to work on!
I'll do:
Probably (not):
Question:
jancborchardt commentedon Jun 10, 2017
@simison great! :) Agree with your suggestion for solution, and also with your doubt about adding a 3rd field (since we have the option to make the password visible).
simison commentedon Jun 10, 2017
and there's always the password recovery (and I second @chaoticfree, it should be visible at login page without needing to type in wrong pass). I didn't find an issue for that tho.
nickvergessen commentedon Jun 12, 2017
Sadly not, 1. depends on the user backend, 2. with encryption enabled and without master key you just loose everything...
We could also just have new password and confirm and then use the modal which you have to enter when you are logged in for too long already.
simison commentedon Jun 12, 2017
True! On the other hand majority of apps/sites asks for the old password first and then new one. Mixing this other way around might be confusing as users expect to see an input for old password in the form.
WDYT? I'm not strongly invested in this so either way is fine! Just wanted to point this out.
Do you know where I could look for the code how to implement such modal?
nickvergessen commentedon Jun 12, 2017
OC.Dialogsis the magic word in JS source code:server/core/js/js.js
Line 1655 in 65d52a1
server/core/js/oc-dialogs.js
Line 28 in a2f6fea
7 remaining items
MorrisJobke commentedon Jan 7, 2019
See also #5181 where it is highlighted, that the password input would be useful for accounts with encryption enabled.
skjnldsv commentedon Jan 8, 2019
I need to stop doing that
Victorybrown commentedon Oct 18, 2020
CarlSchwan commentedon Sep 1, 2022
Done with #33429