Skip to content

[Bug]: internal links don't seem to get resolved properly #32177

Closed

Description

@jospoortvliet

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

It's possible to simply copy the address bar link and send it to another user who has access to the file, for them to open it. This seems, at least for some users in Nc 24RC2, broken. Link for an internal Nextcloud GmbH user to test:
https://cloud.nextcloud.com/apps/files/?dir=/Marketing/Marketing%20Automation%20plan&openfile=5993281
worked for Max, not for Jos and Christoph. Magic!

Possibly related, but only for SMB/LDAP scenario's: #27969

Steps to reproduce

  1. copy address bar to a file/folder
  2. share with a colleague who has access to that file/folder
  3. have them open the link and see the URL in the Breadcrumbs bar, but their root as folder contents

Video (also internal share, as it has some semi-sensitive stuff):
https://cloud.nextcloud.com/f/5993616

Expected behavior

Colleague should see the file be opened.

Installation method

No response

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

internal nextcloud server

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

Activity

  1. CarlSchwan commented on Apr 27, 2022

    @CarlSchwan
    Member

    weird this is working fine for me, could you look into your developer console and see if there is any errors reported?

    Also what browser are you using?

  2. jospoortvliet commented on Apr 27, 2022

    @jospoortvliet
    MemberAuthor

    @CarlSchwan https://cloud.nextcloud.com/f/5995231
    hope it helps. Christoph had the same issue, perhaps you can work with him to debug as I'm not terribly technical :D

  3. PVince81 commented on May 6, 2022

    @PVince81
    Member

    I also couldn't reproduce it so far but what I saw is that when the private link is opened, while the page is loading the "fileid" is not appended yet. It's only after the folder finished loading that we know the fileid and the URL gets adjusted.

    So if someone copies the URL before that it won't contain the file id.

    I believe this is related to the removal of the redirect for performance reasons, the redirect would directly send to the URL containing the fileid to have it initially there: #31143
    The new logic requires first loading the folder to know it.

    One alternative idea would be to adjust the ViewController to pre-fetch the fileid and include it in initialState so that we have it earlier.

  4. alexbijma commented on Aug 24, 2022

    @alexbijma

    not sure if it's important to know, but I faced this issue also in earlier versions of NC. Already in v20 i have the same issue. The url displays: /apps/files/?dir=/&scrollto=Readme (2).md and gives the root folder

  5. szaimen commented on May 22, 2023

    @szaimen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions