Skip to content

[F2V] Migrate tags view #30249

Closed
Closed

Description

@skjnldsv

This ticket is part of the files to vue migration

Goal

Unify and improve the system tags view

QA

  • Display tags as folders (new API ⚠️)
    • Implementing this as a DAV might give us opportunity to directly catch DELETE/PUT/MOVE requests
      BUT it will create issues with the paths considering a file located in dav/USER/files/Photos/vacation.jpg will be seen with a path like dav/USER/tags/Summer 2021 vacations/vacation.jpg while all the actions would expect the real dav path to work 🤔
    • Implementing this with OCS API will allow us to return different data like path that fixes the issue above
  • Opening the tag (folder) list all files belonging to it
  • Actions
    • Rename
    • Delete
    • There is no sidebar for those tags/fake-folders, we need to check how to handle this ⚠️
  • Assess this global way of managing this. Considering it will use the same API as the real Files/Folders: [F2V] Files views API + navigation + base structure #30070, check potential pitfalls of storing and caching "fake folders".
    • Actions might be displayed while not theoretically supporting it on those folders

Future

  • Show most recent/used tags in the navigation same as favorites

Activity

  1. added
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    1. to developAccepted and waiting to be taken care of
    and removed
    0. Needs triagePending check for reproducibility or if it fits our roadmap
    on Dec 13, 2021
  2. added this to the Nextcloud 24 milestone on Dec 13, 2021
  3. icewind1991 commented on Dec 16, 2021

    @icewind1991
    Member

    BUT it will create issues with the paths considering a file located in dav/USER/files/Photos/vacation.jpg will be seen with a path like dav/USER/tags/Summer 2021 vacations/vacation.jpg while all the actions would expect the real dav path to work thinking

    Given that the same problem would exist for other dav views, it probably makes sense to have the view expose some form of "canonical path" to give apps the "expected" path

  4. skjnldsv commented on Dec 21, 2021

    @skjnldsv
    MemberAuthor

    Given that the same problem would exist for other dav views, it probably makes sense to have the view expose some form of "canonical path" to give apps the "expected" path

    Well, the main issue is not about display, but about the context passed to the actions for example.
    If I display a list of files in https://cloud.domain.com/apps/files/tags/Tagged-folder/file.ext, then the actions for a file should still apply to https://cloud.domain.com/remote.php/dav/user/files/path/to/file.ext
    But I guess you can list files with ocs fine, and it can provide different paths. But we need to be careful about potential pitfalls 🤔

  5. Spartachetto commented on Aug 8, 2022

    @Spartachetto

    I do not see in the action list for the "virtual folders" defined by tags the possibility to share all the tagged files with one action. This functionality has been asked several times. If needed I can link the issues that ask for it.

  6. self-assigned this
    on Aug 8, 2023
  7. assigned and unassigned on Sep 17, 2023
  8. added and removed
    1. to developAccepted and waiting to be taken care of
    on Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions