Skip to content

Harden NGINX config - #1674

Merged
ChristophWurst merged 1 commit into
masterfrom
harden/nginx
Oct 24, 2019
Merged

ChristophWurst merged 1 commit into
masterfrom
harden/nginx

Conversation

@rullzer

@rullzer rullzer commented Oct 24, 2019

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer

rullzer commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

/backport to stable17

@rullzer

rullzer commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

/backport to stable16

@rullzer

rullzer commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

/backport to stable15

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@ChristophWurst
ChristophWurst merged commit a8fda56 into master Oct 24, 2019
@ChristophWurst
ChristophWurst deleted the harden/nginx branch October 24, 2019 08:44
@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable17 in #1675

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable16 in #1676

@backportbot-nextcloud

Copy link
Copy Markdown

backport to stable15 in #1677

@jknockaert

Copy link
Copy Markdown
Contributor

I think a feature of nginx was overlooked in this PR. By adding try_files the variable $fastcgi_path_info is reset:
https://trac.nginx.org/nginx/ticket/321
So the fastcgi parameter PATH_INFO will get a different value because of adding try_files to the config.
This can be solved by adding set $path_info $fastcgi_path_info; before try_files, and then assigning $path_info to PATH_INFO.

@rullzer

rullzer commented Oct 24, 2019

Copy link
Copy Markdown
Member Author

@jknockaert could you submit a PR?

jknockaert pushed a commit that referenced this pull request Oct 24, 2019
`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
@jknockaert jknockaert mentioned this pull request Oct 24, 2019
@jknockaert

Copy link
Copy Markdown
Contributor

@rullzer #1679

backportbot-nextcloud Bot pushed a commit that referenced this pull request Oct 24, 2019
`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
backportbot-nextcloud Bot pushed a commit that referenced this pull request Oct 24, 2019
`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
backportbot-nextcloud Bot pushed a commit that referenced this pull request Oct 24, 2019
`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
kesselb pushed a commit that referenced this pull request Nov 20, 2019
`try_files` was added in #1674, but that resets `$fastcgi_path_info`. This PR makes sure PATH_INFO gets the original value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants