Repository navigation
Conversation
The __Host prefix mitigates cookie injection vulnerabilities within potential third-party software sharing the same second level domain. This is one of the metrics used in the Nextcloud security scan. The Dockerfile COPY filename was changed from uploadsize.conf to make it more generic in use. Signed-off-by: danchal <danchal@users.noreply.github.com>
Contributor
|
Do you have any issues with cookies? The __host prefix is already supported by NextCloud and works with Docker. |
Author
|
I found no cookie specific issues with the default setup, however, the Nextcloud security scan does include the __host prefix and it's not possible to achieve an A+ rating without this change. Other than for attaining the A+ rating, I can't say if this change is necessary or not. |
Contributor
|
I cannot reproduce this issue using the latest image version. |
Author
|
My mistake, I just tested a clean docker-compose and was able to attain an A+ rating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The __Host prefix mitigates cookie injection vulnerabilities within potential third-party software sharing the same second level domain.
This is one of the metrics used in the Nextcloud security scan.
This pull request adds the nginx proxy directive proxy_cookie_path to the existing custom directives.
The Dockerfile COPY filename was changed from uploadsize.conf to make it more generic in use.