Repository navigation
Cannot enter comments in Deck 0.5.0 / NC 13.0.7 #704
Description
Just updated Deck to 0.5.0 and ran some tests. Creating a new comment in the timeline seems to be impossible.
Steps to reproduce:
- Click on an existing or new card
- Click on "Zeitachse" (Timeline)
- Enter new comment and click the arrow to the right.
What should happen:
- Comment is created and shown in the list
What actually happens:
- Error message appears: "Absenden des Kommentars ist fehlgeschlagen."
- The arrow becomes an infinitely spinning circle
Nextcloud Versions:
- 13.0.7 (does not work as described above)
- 14.0.3 (No problems)
Excerpt rom the log (level 0):
{"reqId":"W@2S7tyt5AevJM@z@BbqTgAAAA8","level":"error","time":"2018-11-15T15:38:23+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/index.php/apps/deck/cards/126","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJcQAAABE","level":"error","time":"2018-11-15T15:38:26+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/index.php/apps/deck/2/cards/deleted","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJcgAAABM","level":"error","time":"2018-11-15T15:38:26+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/index.php/apps/deck/2/stacks/deleted","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJcwAAABU","level":"error","time":"2018-11-15T15:38:26+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/activity/api/v2/activity/filter?format=json&object_type=deck_card&object_id=126&limit=50&since=0","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJdAAAABc","level":"error","time":"2018-11-15T15:38:26+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/ocs/v2.php/apps/activity/api/v2/activity/filter?format=json&object_type=deck_card&object_id=126&limit=50&since=-1&sort=asc","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJdQAAAA8","level":"error","time":"2018-11-15T15:38:26+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/index.php/apps/deck/%7B%7Bactivity.icon%7D%7D","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S8trXQZtHh6-honcJdgAAABk","level":0,"time":"2018-11-15T15:38:27+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"webdav","method":"REPORT","url":"/remote.php/dav/comments/deckCard/126/","message":"Exception: {"Exception":"Sabre\\DAV\\Exception\\NotFound","Message":"Entity type \"deckCard\" not found.\"","Code":0,"Trace":"#0 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Tree.php(76): OCA\\DAV\\Comments\\RootCollection->getChild('deckCard')\n#1 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Tree.php(71): Sabre\\DAV\\Tree->getNodeForPath('comments\/deckCa...')\n#2 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Connector\/Sabre\/FilesReportPlugin.php(171): Sabre\\DAV\\Tree->getNodeForPath('comments\/deckCa...')\n#3 [internal function]: OCA\\DAV\\Connector\\Sabre\\FilesReportPlugin->onReport('{http:\/\/ownclou...', Array, 'comments\/deckCa...')\n#4 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#5 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/CorePlugin.php(722): Sabre\\Event\\EventEmitter->emit('report', Array)\n#6 [internal function]: Sabre\\DAV\\CorePlugin->httpReport(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#7 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#8 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(479): Sabre\\Event\\EventEmitter->emit('method:REPORT', Array)\n#9 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#10 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Server.php(293): Sabre\\DAV\\Server->exec()\n#11 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/appinfo\/v2\/remote.php(35): OCA\\DAV\\Server->exec()\n#12 \/www\/htdocs\/[anonymized]\/cloud\/remote.php(164): require_once('\/www\/htdocs\/w01...')\n#13 {main}","File":"\/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Comments\/RootCollection.php","Line":150}","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S89rXQZtHh6-honcJdwAAABs","level":"error","time":"2018-11-15T15:38:27+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
{"reqId":"W@2S9wcpKbENaJic5KW7wwAAAA8","level":0,"time":"2018-11-15T15:38:31+00:00","remoteAddr":"[anonymized]","user":"[anonymized]","app":"webdav","method":"POST","url":"/remote.php/dav/comments/deckCard/126/","message":"Exception: {"Exception":"Sabre\\DAV\\Exception\\NotFound","Message":"Entity type \"deckCard\" not found.\"","Code":0,"Trace":"#0 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Tree.php(76): OCA\\DAV\\Comments\\RootCollection->getChild('deckCard')\n#1 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Tree.php(71): Sabre\\DAV\\Tree->getNodeForPath('comments\/deckCa...')\n#2 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Comments\/CommentsPlugin.php(111): Sabre\\DAV\\Tree->getNodeForPath('comments\/deckCa...')\n#3 [internal function]: OCA\\DAV\\Comments\\CommentsPlugin->httpPost(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#4 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/event\/lib\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\n#5 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(479): Sabre\\Event\\EventEmitter->emit('method:POST', Array)\n#6 \/www\/htdocs\/[anonymized]\/cloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))\n#7 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Server.php(293): Sabre\\DAV\\Server->exec()\n#8 \/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/appinfo\/v2\/remote.php(35): OCA\\DAV\\Server->exec()\n#9 \/www\/htdocs\/[anonymized]\/cloud\/remote.php(164): require_once('\/www\/htdocs\/w01...')\n#10 {main}","File":"\/www\/htdocs\/[anonymized]\/cloud\/apps\/dav\/lib\/Comments\/RootCollection.php","Line":150}","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0","version":"13.0.7.2"}
Activity
juliusknorr commentedon Nov 15, 2018
This one looks strange but I cannot reproduce this on 13. Is there any difference in configuration between the 13 and 14 servers, you have tested this on?
"Entity type "deckCard" not found.
bpcurse commentedon Nov 15, 2018
@juliushaertl Thank you for your fast reply and your work!
Yes, i'm afraid these are completely different servers and setups with many differences in apps and user count. The 14.0.3 is a relatively new self administered physical server, with almost no users at the moment. The 13.0.7 is a pretty long running shared hosting server with 100+ users. Will try to deliver detailed configuration and a test with another browser later, probably tomorrow.
I am thinking about a server update from 13.0.7 to 14.0.3, but this version still isn't tagged as 'production'. I assume this could solve the problem, but maybe others might run into this as well.
bpcurse commentedon Nov 16, 2018
The same happens using Chromium instead of Firefox.
Here are the configuration details:
13.0.7 shared hosting server
Operating system: Linux 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64
Webserver: Apache (fpm-fcgi)
Database: mysql 5.7.21
PHP version:
7.1.19-nmm1 Modules loaded: Core, date, libxml, openssl, pcre, zlib, bcmath, bz2, calendar, ctype, dom, hash, filter, ftp, gettext, SPL, iconv, json, mbstring, posix, Reflection, session, standard, shmop, SimpleXML, soap, exif, sysvsem, sysvshm, tokenizer, wddx, xml, xmlreader, xmlwriter, zip, cgi-fcgi, propro, raphf, http, mysqlnd, PDO, curl, dba, fileinfo, gd, gender, gmp, htscanner, imagick, imap, interbase, intl, ldap, mailparse, mcrypt, mongodb, mysqli, OAuth, odbc, pdo_dblib, pdo_mysql, PDO_ODBC, pdo_pgsql, pdo_sqlite, pgsql, Phar, pspell, recode, SourceGuardian, sqlite3, tidy, xsl, ionCube Loader
Nextcloud version: 13.0.7 - 13.0.7.2
14.0.3 physical server
Operating system: Linux 4.14.68-1-MANJARO #1 SMP PREEMPT Wed Sep 5 19:07:05 UTC 2018 x86_64
Webserver: nginx/1.14.0 (fpm-fcgi)
Database: mysql 10.1.35
PHP version:
7.2.9 Modules loaded: Core, date, libxml, openssl, pcre, zlib, ctype, dom, fileinfo, filter, hash, json, mbstring, pcntl, SPL, PDO, bz2, posix, readline, Reflection, session, SimpleXML, standard, tokenizer, xml, xmlreader, xmlwriter, mysqlnd, cgi-fcgi, Phar, curl, exif, ftp, gd, iconv, imap, intl, pdo_mysql, pdo_pgsql, pgsql, zip, apcu, igbinary, imagick, mongodb, redis, Zend OPcache
Nextcloud version: 14.0.3 - 14.0.3.0
juliusknorr commentedon Nov 17, 2018
Probably related to #707
juliusknorr commentedon Nov 17, 2018
@bpcurse Just to make sure, is the comments app enabled on both instances?
bpcurse commentedon Nov 17, 2018
@juliushaertl Comments app is enabled on both instances. Version 1.3.0 (on 13.0.7) and version 1.4.0 on (on 14.0.3).
ashgoodman commentedon Nov 19, 2018
Same issue
Comments enabled
Nextcloud 13 via snap
Console gives the following message
Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”).
That message appears when a card is clicked on
Also, getting message that remote.php cannot be found
juliusknorr commentedon Nov 19, 2018
@bpcurse Any change you can apply this patch to the deck app and check if the two log message appears in the log when browsing https://yournextcloud/remote.php/dav/comments (with debug mode enabled on your instance you can just open this in the browser)
juliusknorr commentedon Nov 19, 2018
Same for @ashgoodman as well 😉 Maybe we can track down the issue then a bit.
ashgoodman commentedon Nov 19, 2018
Applied the patch
I dont get the error logs when navigating to .../remote.php/dav/comments in the browser, but still cant post a comment and still getting same error in console when I click on a card
bpcurse commentedon Nov 19, 2018
@juliushaertl
ashgoodman commentedon Nov 20, 2018
Disabled Deck, copied Application.php in full from https://github.com/nextcloud/deck/blob/master/lib/AppInfo/Application.php over my installs copy
Re enabled deck
Comments work!!
ashgoodman commentedon Nov 20, 2018
However the notification email does not contain the name of the person who commented nor the content of the comment email just says:
putt1ck commentedon Nov 20, 2018
I think this is a separate bug, as we also see this behaviour in NC14.03.
ashgoodman commentedon Nov 20, 2018
Well at least we are getting closer :)
Once the email notifications are fixed I think its ready to be used for team PM
Cant wait to migrate from Wekan to Deck full time.
juliusknorr commentedon Nov 20, 2018
@ashgoodman Yes, please open a separate issue for the email notification. 😉
Good to hear that it works now. I assue there has been something wrong during update then or opcache is somehow not up to date 😞
@bpcurse Maybe you can also try replacing the files manually with the ones from the release package and restart the webserver?
putt1ck commentedon Nov 20, 2018
New issue created #721
bpcurse commentedon Nov 20, 2018
@ashgoodman Nice and simple trick! 👍
I didn't even copy Application.php. Only deactivated deck, switched to files, switch back to apps and reactivated it. That's all, it works. Weird bits and bytes 🐵
(And removed the logger patch from Application.php)
@juliushaertl Should we close this now as the bug is extremely easy to handle? Maybe it is not even deck's fault?
Thank you for the support!
juliusknorr commentedon Nov 20, 2018
Yes, let's close it since it is pretty hard to reproduce and we don't have any hints why this might have failed.
juliusknorr commentedon Nov 22, 2018
Just out of interest @bpcurse @ashgoodman Can you post me your php opcache settings? I would really like to know if there is anything that causes your php runtime from recognizing the new files.
bpcurse commentedon Nov 22, 2018
@juliushaertl
The 13.0.7 instance is on a shared hosting server.
Here's the setup warning I cannot resolve due to limited access:
anojht commentedon Dec 16, 2018
EDIT: Please ignore since disabling the Deck app and re-enabling fixed the issue!
Hello I am also having this issue without any messages in the logs. When I attempt to post a comment in the Timeline section I get,
Posting the comment failedNC - 14.0.4
Deck - 0.5.1
I get a HTTP 404 error when attempting to post a comment:
core.js?v=9b50fb98-31:5729 POST https://{server_url}/remote.php/dav/comments/deckCard/50/ 404The request body:
{"actorId":"anojh","actorDisplayName":"Anojh","actorType":"users","verb":"comment","message":"Test","creationDateTime":"Sun, 16 Dec 2018 23:19:01 GMT","objectType":"deckCard"}juliusknorr commentedon Dec 20, 2018
@blizzz Do you have any idea why the comments entity type is not available until the users have disabled and enabled the deck app again? (I cannot reproduce it so it just happens on some setups)
This is how we register the entity: https://github.com/nextcloud/deck/blob/master/lib/AppInfo/Application.php#L128-L148
blizzz commentedon Dec 20, 2018
@juliushaertl there's no logic that kicks in when the app is enabled. Perhaps we have a hidden race condition somewhere.
rasos commentedon Mar 26, 2019
Same issue here with NC 13.0.5: comments are not stored, however disabling / enabling Deck 0.5.2 as recommended in this issue does not help either. Nothing suspicious in Logfile. Comments work in other apps (Files).
How could I further debug this?
deckCard appear in webdav nodes
