[WSHAPER]

The app_api OCS endpoint /ocs/v2.php/apps/app_api/api/v1/info/nextcloud_url/absolute answers with a dict ({"absolute_url": ...}). generate_document and generate_image f-stringed the whole response into their download links, so every link came out as {'absolute_url': 'https://...'}/104/output-file/.../download. This extracts absolute_url after the call in both tools.

Steps to reproduce

1. ask the assistant to generate a document via the generate_document tool
2. the tool fetches the instance URL from the endpoint above, which returns a dict, and f-strings it whole into the download link at both return sites (slides and the default file path), with no absolute_url extraction (ex_app/lib/all_tools/doc_gen.py)
3. the chat model transcribes the mangled URL with a stray brace
4. generate_image builds its link the same way (ex_app/lib/all_tools/image_gen.py)

Expected behaviour

every generate_document and generate_image link resolves; chat links fetch 200 consistently

Actual behaviour

links are mangled and 404 roughly two of three times in live testing

Fix

Extract absolute_url from the OCS response right after the call, in ex_app/lib/all_tools/doc_gen.py and ex_app/lib/all_tools/image_gen.py.

Testing

tests/test_doc_gen_links.py runs both tools against a hermetic fake whose nextcloud_url endpoint returns the dict shape the real controller returns (this is how the bug escaped: a fake answering with a bare string cannot see it). It covers both generate_document return sites (default file output and slides output) and the generate_image link, and asserts the links contain the bare URL plus the task path, with no dict-repr artifacts and no stray braces.

Cross-references

• Image generation produces a broken link #46
  • closed, the old hardcoded-domain bug, different cause, no re-reports since
• Fix: output file url generation #52
  • merged, introduced the raw dict f-string this PR fixes
• Context Agent fails after any message within Nextcloud Assistant #47
  • closed, keyword match only
• feat: Add an nc link parser tool #234
  • closed, keyword match only
• Read Emails #104
  • closed, keyword match only

No existing issue or PR found for this defect (searched this repo's issues and PRs, 2026-10-22).

---

_{Assisted by opencode with zai/glm-5.3, reviewed by WSHAPER}