Repository navigation
fix(tools): accept slide_deck_source in task outputs - #286
Merged
Merged
Conversation
A provider may emit the deck's Markdown source alongside the deck as a second output file; run_task currently rejects it, so the chat agent drops the source. Add slide_deck_source to ACCEPTED_OUTPUT_KEYS so such outputs pass the whitelist. Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com> Assisted-by: opencode (zai/glm-5.3)
marcelklehr
approved these changes
Oct 22, 2026
WSHAPER
added a commit
that referenced
this pull request
Oct 25, 2026
Add a chat tool that schedules the marp_slides ExApp's deck generation task through the shared run_task helper. The tool takes a deck brief (the provider's own AI authors the full Marp Markdown from it), not slide contents, and returns the assistant download link for the generated PPTX. Availability is gated on the task type being registered server-side. The link correctly extracts absolute_url from the app_api OCS response dict rather than f-stringing the whole response. Depends on: #286 Assisted-by: opencode (zai/glm-5.3) Signed-off-by: WSHAPER <42714629+WSHAPER@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A deck-generation task type can emit its Markdown source as
slide_deck_sourcealongside the deck itself, enabling a small-edits-instead-of-recompute flow.run_taskvalidates task outputs againstACCEPTED_OUTPUT_KEYS, which still lacks that key, so the chat agent cannot see or hand back the second output file. The provider reports{"slide_deck": id, "slide_deck_source": md_id}, and an output that carries only the source key is rejected outright.Change
ACCEPTED_OUTPUT_KEYSinex_app/lib/all_tools/lib/task_processing.pygainsslide_deck_source. Outputs carrying the source key now pass validation, so tooling can surface the source link next to the deck link, or a follow-up edit flow can consume it with the original prompt. Unknown keys are still rejected as before.Testing
Adds
tests/test_task_processing_keys.pywith a stubbed Nextcloud app: every accepted key passes,slide_deck_sourcepasses alone and alongsideslide_deck, and an unknown key still raises.Alternatives considered
No issue or PR found for
ACCEPTED_OUTPUT_KEYSwhitelisting of new output keys, multiple output files per task, or consuming a task's own output for iterative editing.Cross-references
Assisted by opencode with zai/glm-5.3, reviewed by WSHAPER