Repository navigation
Do not include js in the repository #476
Description
This tutorial should be used to develop apps that will most likely not be shipped with the server. So there's no need to include the compiled js.
We should avoid including the js in the repo when possible because:
- It leads to conflicts on rebases that would otherwise be smooth.
- It requires rebuilding the js as a production build for every pull request.
- It requires additional consistency checks in ci to ensure js is updated.
- It increases the repo size significantly.
Activity
susnux commentedon Feb 15, 2023
I think ´js/` is included so users can directly test it without installing node dependencies and building the js assets:
https://github.com/nextcloud/app-tutorial#try-it
max-nextcloud commentedon Feb 20, 2023
Good point. On the other hand if you want to make changes you will need to compile the js anyway. And if people use this as a template for their own app they will start with an included js which can be annoying.
So I agree... not an obvious decision here.