Skip to content

Image::place preserves alpha channel - #92

Merged
dg merged 2 commits into
nette:masterfrom
dg:alpha
Apr 19, 2016
Merged

dg merged 2 commits into
nette:masterfrom
dg:alpha

Conversation

@dg

@dg dg commented Nov 11, 2015

Copy link
Copy Markdown
Member

Related to #90

@radekdostal

Copy link
Copy Markdown

@dg Your solution is amazing!
For example: two images 620x385px
With 4fcb6e7 my script runs about one second.
With abfcf39 even just half a second.
(With #90 the script runs about 17 seconds).

@enumag

enumag commented Nov 11, 2015

Copy link
Copy Markdown
Contributor

@dg Awesome!

@dg

dg commented Nov 11, 2015

Copy link
Copy Markdown
Member Author

It is still order of magnitudes slower than imagecopymerge for images without alpha. And I don't know how to detect whether alpha is used or not.

@radekdostal

Copy link
Copy Markdown

@dg

dg commented Nov 11, 2015

Copy link
Copy Markdown
Member Author

It is not about files, but about GD images in memory.

@radekdostal

Copy link
Copy Markdown

What about php://memory wrapper?
In this code exists method _parsepng() which parses PNG header.

@dg
dg force-pushed the master branch 2 times, most recently from 46f5434 to ecbbdfc Compare December 3, 2015 12:21
@dg dg changed the title Image::place preserves alpha channel [WIP] Image::place preserves alpha channel Apr 19, 2016
@dg
dg merged commit 88fab3f into nette:master Apr 19, 2016
@dg
dg deleted the alpha branch April 19, 2016 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants