Repository navigation
Re-apply xterm theme when app theme changes - #62
Merged
Merged
Conversation
Extract theme construction into buildTerminalTheme() and watch :root for data-theme / style mutations so the terminal re-skins live alongside the rest of the app instead of staying frozen at mount time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildTerminalTheme()(reads--color-app/--color-fg-brightfrom:root).MutationObserverondocument.documentElementwatchingdata-themeand inlinestyleso the terminal re-skins live whenevertheme-apply.tsswaps the app theme — both built-in switches and custom-theme overrides.Previously the terminal pulled its background/foreground from CSS variables once at mount and never re-read them, so switching themes left the terminal frozen at whatever it was painted with at init. We didn't notice this before because every theme was dark — switching between dark themes left the terminal looking close enough to right that nothing was obviously broken. With the new light/dark/system mode + custom themes from #47, the mismatch is glaring.
MutationObserveris used rather than keying offuseActiveTheme()to avoid a child-before-parentuseEffectrace where XTerminal would re-read CSS vars beforetheme-apply.tshad written the new values.Test plan
npm run typecheckcleannpx electron-vite buildclean🤖 Generated with Claude Code