Repository navigation
Add GitHub setup banner on app launch - #2
Merged
Merged
Conversation
Prompts users to connect a GitHub token if none is stored, linking directly to Settings. Dismissal persists via localStorage, and the banner auto-hides once a token is saved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
frenchie4111
force-pushed
the
add-gh-setup-banner
branch
from
April 10, 2026 14:30
6d730f6 to
315ae64
Compare
3 of 6 tasks
tresat
added a commit
to tresat/harness
that referenced
this pull request
Jul 24, 2026
- Extract normalizeAlias() + ALIAS_MAX_LEN in shared/state/aliases.ts; IPC handler, MCP control-server dep, and control-server response echo all use it so the trim/clamp logic can't drift (fixes ness-dev#2) - useHotkeys skips when focused element (or ancestor) has data-hotkeys="ignore"; AliasEditor input opts in so Cmd+W / Cmd+K / etc. don't fire while renaming. Opt-in (not a general "skip inputs" rule) because xterm's hidden textarea would otherwise break every terminal-time hotkey (fixes ness-dev#4) - useAliasForPath now accepts string | null | undefined; App.tsx window title read no longer needs the '?? ...' fallback subscription to a permanently-empty key (fixes ness-dev#7) - MCP control-server response includes clamped: true when the caller's input differed from what got stored; the set_worktree_alias tool surfaces this to the agent as "input was normalized" so silent whitespace/length changes are discoverable (fixes ness-dev#8) - Add control-server.test.ts covering POST/DELETE /aliases end-to-end: scope-fallback, clamp reporting, empty-clears-alias, and 400 on no worktreePath + no scope (fixes ness-dev#9) - displayLabel docstring now explains the resolution order, the machine-facing exclusion, and the per-id selector pairing (fixes ness-dev#10)
frenchie4111
pushed a commit
that referenced
this pull request
Jul 24, 2026
- Extract normalizeAlias() + ALIAS_MAX_LEN in shared/state/aliases.ts; IPC handler, MCP control-server dep, and control-server response echo all use it so the trim/clamp logic can't drift (fixes #2) - useHotkeys skips when focused element (or ancestor) has data-hotkeys="ignore"; AliasEditor input opts in so Cmd+W / Cmd+K / etc. don't fire while renaming. Opt-in (not a general "skip inputs" rule) because xterm's hidden textarea would otherwise break every terminal-time hotkey (fixes #4) - useAliasForPath now accepts string | null | undefined; App.tsx window title read no longer needs the '?? ...' fallback subscription to a permanently-empty key (fixes #7) - MCP control-server response includes clamped: true when the caller's input differed from what got stored; the set_worktree_alias tool surfaces this to the agent as "input was normalized" so silent whitespace/length changes are discoverable (fixes #8) - Add control-server.test.ts covering POST/DELETE /aliases end-to-end: scope-fallback, clamp reporting, empty-clears-alias, and 400 on no worktreePath + no scope (fixes #9) - displayLabel docstring now explains the resolution order, the machine-facing exclusion, and the per-id selector pairing (fixes #10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pl-20+drag-regionso they clear the macOS traffic lights while staying draggable (buttons markedno-drag)Test plan
🤖 Generated with Claude Code