Repository navigation
add more patches for undocumented fields and messages - #32
Open
ThomasKuehne wants to merge 1 commit into
Open
ThomasKuehne wants to merge 1 commit into
ThomasKuehne wants to merge 1 commit into
Conversation
Owner
|
Hi @ThomasKuehne ! Sorry, somehow I missed this, but this is huge, thank you! |
nbr23
self-requested a review
November 4, 2026 02:34
nbr23
requested changes
Nov 4, 2026
nbr23
left a comment
Owner
There was a problem hiding this comment.
Thanks again, I took a deeper look. A couple of notes:
- speeds with StandardUnitsDataProcessor: it multiplies every *_speed field by 3.6, assuming m/s. lactate_threshold_speed is already in km/h, so you get 47.88 km/h instead of 13.3. auto_climb_vertical_speed (meter per hour, scale=27.778) has the same problem. can we keep those in m/s like the sdk does?
- units: the sdk uses s, m, bpm, watts, C, but the patches use seconds, meter, beats per minute, watt, celsius. let's do like the sdk here too
- timestamp (253): none of the new messages define it, so in gps_event, sleep_insight, best_effort, user_metrics etc. it shows up as a raw unknown_253. could you add it as date_time on these?
- types: the generator takes profile type names, so:
- local_timestamp, start_time, sleep_start_time, etc can be date_time / local_date_time instead of uint32
- the enums can point at real types where you know them, e.g. best_effort.sport shows 1 instead of running
also, if you have files (ideally reconstructed/anonymised, not real) covering a couple of the new messages, a test would be nice.
and finally, I just merged the auto update so you'll need to rebase + rerun the profile gen on the PR 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.