Skip to content

add more patches for undocumented fields and messages - #32

Open
ThomasKuehne wants to merge 1 commit into
nbr23:masterfrom
ThomasKuehne:undocumented
Open

ThomasKuehne wants to merge 1 commit into
nbr23:masterfrom
ThomasKuehne:undocumented

Conversation

@ThomasKuehne

Copy link
Copy Markdown

No description provided.

@nbr23 nbr23 self-assigned this Nov 3, 2026
@nbr23

nbr23 commented Nov 3, 2026

Copy link
Copy Markdown
Owner

Hi @ThomasKuehne ! Sorry, somehow I missed this, but this is huge, thank you!
Can you share how / where you got these from?

@nbr23
nbr23 self-requested a review November 4, 2026 02:34

@nbr23 nbr23 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, I took a deeper look. A couple of notes:

  1. speeds with StandardUnitsDataProcessor: it multiplies every *_speed field by 3.6, assuming m/s. lactate_threshold_speed is already in km/h, so you get 47.88 km/h instead of 13.3. auto_climb_vertical_speed (meter per hour, scale=27.778) has the same problem. can we keep those in m/s like the sdk does?
  2. units: the sdk uses s, m, bpm, watts, C, but the patches use seconds, meter, beats per minute, watt, celsius. let's do like the sdk here too
  3. timestamp (253): none of the new messages define it, so in gps_event, sleep_insight, best_effort, user_metrics etc. it shows up as a raw unknown_253. could you add it as date_time on these?
  4. types: the generator takes profile type names, so:
    • local_timestamp, start_time, sleep_start_time, etc can be date_time / local_date_time instead of uint32
    • the enums can point at real types where you know them, e.g. best_effort.sport shows 1 instead of running

also, if you have files (ideally reconstructed/anonymised, not real) covering a couple of the new messages, a test would be nice.

and finally, I just merged the auto update so you'll need to rebase + rerun the profile gen on the PR 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants