[xmh0511]

No description provided.

[SajjadPourali]

I am hesitant to use this dependency even in the examples since it is left unmaintained.

[SajjadPourali]

It is better to create two types for the IpStackStream: one for UnknownTransport, which we know is IP but is neither TCP nor UDP, and another for UnknowNetwork for anything that is not IP. I believe these types allow users to implement their protocols manually.

---

Since ICMP is not primarily designed to transfer data, we have to create an enum that supports the most useful types of ICMP in the IpStack usage scenarios, such as Echo.

[SajjadPourali]

Something like this?

670226a

---

ipstack/src/stream/mod.rs

Lines 12 to 17 in 670226a

	pub enum IpStackStream {
	Tcp(IpStackTcpStream),
	Udp(IpStackUdpStream),
	UnknownTransport(IpStackUnknownTransport), // todo: fix lint error
	UnknownNetwork(Vec<u8>), // todo: fix lint errorP
	}

[xmh0511]

I think providing the raw packet produced by tun for all the other cases other than tcp and udp has the maximum flexible because we may want to do the following things:

1. process the packet by using the familiar crate.
2. send the complete packet to the remote to be processed.

Even for Icmp packet, if we pre-process it to produce IpStackUnknownTransport, we can only get the payload, or we must re-produce the original packet from the result, which is not necessary.

[SajjadPourali]

@xmh0511: could you please check examples/tun.rs in the main branch?

https://github.com/narrowlink/ipstack/blob/main/examples/tun.rs#L113-L134

[xmh0511]

@SajjadPourali I have tried the latest version. Currently, in the branch IpStackStream::UnknownTransport(u), u.payload() will return the payload part of the IP packet, which is the ICMP message, and u.send just need the ICMP message too, right?

[SajjadPourali]

@SajjadPourali I have tried the latest version. Currently, in the branch IpStackStream::UnknownTransport(u), u.payload() will return the payload part of the IP packet, which is the ICMP message, and u.send just need the ICMP message too, right?

True, there also another one that called UnknownNetwork that is similar to the raw that you mentioned.