Repository navigation
Fix HTML output path in Python 3 visualizer - #37
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass the configured output directory when generating the HTML page in the Python 3 visualization script. Without this argument, using
-ht/--htmlraises aTypeErrorafter the image and legend are written.Fixes #36.
Validation
-htand-of; it exited 0 and wrote the requested HTML page, image, and legend under the output directory.git diff --checkpassed.The focused visualization run used a minimal local
pylabimport stub because that optional plotting module is not installed in the validation environment. A full native build is unavailable because the DynamoRIO submodule is uninitialized and the repository's legacy toolchains are absent.