Skip to content

Fix HTML output path in Python 3 visualizer - #37

Open
dajiaohuang wants to merge 1 commit into
mxmssh:masterfrom
dajiaohuang:fix/visualizer-html-output-folder
Open

dajiaohuang wants to merge 1 commit into
mxmssh:masterfrom
dajiaohuang:fix/visualizer-html-output-folder

Conversation

@dajiaohuang

Copy link
Copy Markdown

Summary

Pass the configured output directory when generating the HTML page in the Python 3 visualization script. Without this argument, using -ht/--html raises a TypeError after the image and legend are written.

Fixes #36.

Validation

  • Ran the Python 3 script against a minimal two-call trace with -ht and -of; it exited 0 and wrote the requested HTML page, image, and legend under the output directory.
  • Parsed the modified script with Python's AST parser.
  • git diff --check passed.

The focused visualization run used a minimal local pylab import stub because that optional plotting module is not installed in the validation environment. A full native build is unavailable because the DynamoRIO submodule is uninitialized and the repository's legacy toolchains are absent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3 visualizer crashes when --html is used

1 participant