Repository navigation
Conversation
Preview discovery decided whether a listener was a web server by sending it GET and a TLS ClientHello. Owned listeners include every process a Claude agent starts, since they inherit T3CODE_THREAD_ID, so the probes reached private ports. A Gradle test worker takes the first connection on its port as its worker, so a probe failed the build with no failing test. Unity, Flutter's test loader and gcloud's OAuth callback fail the same way. Owned listeners are now listed from process ownership alone, and only configured URLs get a request. T3CODE_PORT_DISCOVERY=0 turns the listing off. This is upstream PR 26289 preview-probes-binary-services by shivamhwp. Without a probe the list would also show ports that exist for moments, so a new listener appears once it has been up for one poll interval. Listeners already up when a client first looks appear at once.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview discovery decided whether a local port was a web server by sending it
GET /and a TLS ClientHello. Every process a Claude agent starts counts as owned, so those probes reached private ports. A Gradle test worker takes the first connection on its port as its worker, so a probe failed the build with no failing test.Owned ports are now listed from process ownership alone, and only configured Preview URLs get a request.
T3CODE_PORT_DISCOVERY=0turns the listing off. This carries upstreampingdotgg/t3code#26289preview-probes-binary-services by shivamhwp, for issuepingdotgg/t3code#26279.On top of that PR:
http://localhost:<port>.Drop this layer when upstream merges
pingdotgg/t3code#26289, keeping whichever of the additions upstream did not take.Validation:
PortScanner.test.tspasses, and the listing and configured-URL assertions fail without their changes. Before the change, a Gradle build with an untagged daemon had no errors in 9 of 9 runs and a tagged daemon failed 1 of 13, with a stand-in probe on first sight failing 6 of 6.