Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Count the missing lazily evaluated operators in the JS-family cyclomatic complexity.
??,??=,||=and&&=short-circuit like||and&&, but the Mozjs, JavaScript, TypeScript and TSX implementations only counted||and&&. This addsQMARKQMARK,QMARKQMARKEQ,AMPAMPEQandPIPEPIPEEQto the fourCyclomaticimpls, with one test per language. The new tests fail onmaster(sum 2.0 instead of 6.0) and pass with this change;cargo test --libpasses.?.is left out on purpose: the issue lists it with a "maybe", and it is not a logical operator, so counting it is a separate decision for the maintainers.Related to #788