Skip to content

Pair old and new metrics files by path in the grammar check tasks - #1262

Closed
marco-c wants to merge 1 commit into
masterfrom
grammar-check-pairing
Closed

marco-c wants to merge 1 commit into
masterfrom
grammar-check-pairing

Conversation

@marco-c

@marco-c marco-c commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator

Fixes #1261.

Instead of running json-minimal-tests on the two metrics directories, which compares unrelated files with the same name and skips most of the others, compare each old file with the new one at the same path, and only run json-minimal-tests on the pairs that differ.

Tested locally with a stub json-minimal-tests on two copies of the metrics of ~300 files from mozilla-central, one of them modified (one of the several prop-desc.js files): only that pair was passed to the tool.

Given two directories, json-minimal-tests walks them in parallel and
compares two entries only if their file names match. The walks quickly
get misaligned, so files with the same name in different directories
were compared with each other, and most other files were never compared.

Compare each old file with the new file at the same path instead, and
only run json-minimal-tests on the pairs that differ.

Fixes #1261.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (d04dc9d) to head (3db6946).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   90.43%   90.43%           
=======================================
  Files          62       62           
  Lines       16438    16438           
=======================================
  Hits        14866    14866           
  Misses       1572     1572           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marco-c

marco-c commented Nov 21, 2026

Copy link
Copy Markdown
Collaborator Author

I prefer to fix this upstream, PR at Luni-4/json-minimal-tests#2.

@marco-c marco-c closed this Nov 21, 2026
@marco-c
marco-c deleted the grammar-check-pairing branch November 21, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grammar check tasks compare unrelated files and skip most of the others

2 participants