Repository navigation
Conversation
Given two directories, json-minimal-tests walks them in parallel and compares two entries only if their file names match. The walks quickly get misaligned, so files with the same name in different directories were compared with each other, and most other files were never compared. Compare each old file with the new file at the same path instead, and only run json-minimal-tests on the pairs that differ. Fixes #1261.
3 tasks done
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 62 62
Lines 16438 16438
=======================================
Hits 14866 14866
Misses 1572 1572 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I prefer to fix this upstream, PR at Luni-4/json-minimal-tests#2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1261.
Instead of running
json-minimal-testson the two metrics directories, which compares unrelated files with the same name and skips most of the others, compare each old file with the new one at the same path, and only runjson-minimal-testson the pairs that differ.Tested locally with a stub
json-minimal-testson two copies of the metrics of ~300 files from mozilla-central, one of them modified (one of the severalprop-desc.jsfiles): only that pair was passed to the tool.