Repository navigation
Zip Windows release binaries with the tar built into Windows - #1251
Merged
Merged
Conversation
7-Zip is no longer installed on the proj-relman/win2022 worker image, so the 7z commands in the build_windows_release task would fail. Windows ships bsdtar as %SystemRoot%\System32\tar.exe, which writes zip files with -a. Call it by full path, as msys2's GNU tar (which cannot write zip files) is also on PATH.
Member
Author
|
CI failure unrelated - fixed in #1252 |
marco-c
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build_windows_releasetask zips its binaries with7z, but 7-Zip is no longer installed on theproj-relman/win2022image (it was dropped when relman moved to the sharedgeneric-worker-win2022image in May 2023, after the last release, v0.0.25). The next tag build would fail at that step:where 7zfinds nothing on a current worker.This uses the bsdtar that ships with Windows instead (
tar -awrites a zip based on the file extension). It's called by full path because msys2's GNU tar, which can't write zips, is also onPATH. I ran these exact commands on the same image (task): both zips contain just the.exeat the root, as before, and extract withExpand-Archive.The release task only runs on tags, so this PR's CI doesn't exercise it.