Skip to content

Zip Windows release binaries with the tar built into Windows - #1251

Merged
marco-c merged 2 commits into
mozilla:masterfrom
petemoore:release-zip-with-builtin-tar
Nov 19, 2026
Merged

marco-c merged 2 commits into
mozilla:masterfrom
petemoore:release-zip-with-builtin-tar

Conversation

@petemoore

Copy link
Copy Markdown
Member

The build_windows_release task zips its binaries with 7z, but 7-Zip is no longer installed on the proj-relman/win2022 image (it was dropped when relman moved to the shared generic-worker-win2022 image in May 2023, after the last release, v0.0.25). The next tag build would fail at that step: where 7z finds nothing on a current worker.

This uses the bsdtar that ships with Windows instead (tar -a writes a zip based on the file extension). It's called by full path because msys2's GNU tar, which can't write zips, is also on PATH. I ran these exact commands on the same image (task): both zips contain just the .exe at the root, as before, and extract with Expand-Archive.

The release task only runs on tags, so this PR's CI doesn't exercise it.

7-Zip is no longer installed on the proj-relman/win2022 worker image, so
the 7z commands in the build_windows_release task would fail. Windows
ships bsdtar as %SystemRoot%\System32\tar.exe, which writes zip files
with -a. Call it by full path, as msys2's GNU tar (which cannot write
zip files) is also on PATH.
@petemoore

Copy link
Copy Markdown
Member Author

CI failure unrelated - fixed in #1252

@marco-c
marco-c merged commit 0a4a235 into mozilla:master Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants