Repository navigation
ci: run pull requests from outside the org as untrusted - #3752
Merged
Merged
Conversation
Contributor
Author
|
r? @marco-c. This unblocks taskgraph for bugbug. |
marco-c
approved these changes
Oct 30, 2026
| description: Build docker image of code review backend | ||
| owner: bastien@mozilla.com | ||
| source: https://github.com/mozilla/code-review | ||
| - $if: 'tasks_for != "github-pull-request-untrusted"' |
Collaborator
There was a problem hiding this comment.
An inclusive instead of an exclusive condition would be better long term to prevent accidental scheduling.
Contributor
Author
There was a problem hiding this comment.
I agree in the long run. In the short term, .taskcluster.yml will be rewritten in #3264. So this if-statement won't exist anymore.
bhearsum
added a commit
to mozilla-releng/fxci-config
that referenced
this pull request
Oct 30, 2026
Collaborator
|
This looks like it broke dependabot, eg: #3734 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
pullRequests: public, outside contributors' pull requests run with thepull-requestrole, which writes PR caches and inserts PR index entries.public_restrictedruns them aspull-request-untrustedinstead. Community-tc #1038 grants that role route-only PR scopes andlowesttask creation, with no cache writes or privileged capability.Changes:
pullRequests: public_restricted.tasks_for == "github-pull-request"checks now usetasks_for[:19], so untrusted events read the fork's head.Merge order:
.taskcluster.ymlto taskgraph #3264