You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add a report showing files with zero coverage on a platform but not on another #23
changed the title [-]shipit_code_coverage: Add a report showing files with zero coverage on a platform but not on another[/-][+]Add a report showing files with zero coverage on a platform but not on another[/+]on Sep 23, 2018
Hey @marco-c i can understand the python based code and the frontend part also. But after that, "
then the actual implementation of the platform-difference report generation code and platform-difference frontend code ", i did not understood this.
I am also trying to setup development env, I am following this guide https://docs.mozilla-
releng.net/develop/contribute.html. I have successfully ran these commands.
rahul (master) release-services $ ./please shell codecoverage/bot
OK
But on this command i am getting the following error.
rahul (master) release-services $ ./please run codecoverage/bot
Error: Application codecoverage/bot is not configured to be runnable.
I already have docker and git installed. Can you tell me how to communicate with you using an irc, i am using mobbit but channel #ci ( Mozilla [webirc] is not working. Also can you suggest a better irc.
Thanks.
Hey @marco-c i can understand the python based code and the frontend part also. But after that, "
then the actual implementation of the platform-difference report generation code and platform-difference frontend code ", i did not understood this.
I meant, after studying that code, then you can go on and start the implementation of the report showing files with zero coverage on a platform but not on another.
But on this command i am getting the following error.
rahul (master) release-services $ ./please run codecoverage/bot
Error: Application codecoverage/bot is not configured to be runnable.
Having a shell will be enough, you won't need to run the project.
I already have docker and git installed. Can you tell me how to communicate with you using an irc, i am using mobbit but channel #ci ( Mozilla [webirc] is not working. Also can you suggest a better irc.
I've seen you around in #release-services, so I assume you found a solution for this.
May I know if platform in this context refers to the build platform such as linux64-ccov or linux64-jsdcov?
I suppose the report will be rendered on the front-end when a user selects a specific platform as an option, for instance, if I want to view all zero coverage JavaScript files on a specific platform say P1, I'd select the filers - JavaScript and platform P1
Please let me know if I've misinterpreted the workflow of querying zero coverage report on a platform.
We want to produce a report that shows files that have zero coverage on a platform (e.g. Windows) but have coverage > zero on another platform (e.g. Linux).
This will allow us to see files which could be conditionally compiled.
The platforms for now should just be Linux and Windows, we can add Mac later.
On 8 Jan 2019, at 7:31 AM, m-agboola ***@***.***> wrote:
Alright @marco-c
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Activity
rv404674 commentedon Sep 22, 2018
Hi @marco-c , can i take up this issue.
marco-c commentedon Sep 23, 2018
Hey @rv404674 , you sure can! This is a pretty involved
good first bugthough, as it will require understanding of the zero coverage report generation code (https://github.com/mozilla/release-services/blob/master/src/codecoverage/bot/code_coverage_bot/zero_coverage.py), the zero coverage report frontend (https://github.com/marco-c/code-coverage-reports/tree/gh-pages) and then the actual implementation of the platform-difference report generation code and platform-difference frontend code (which will share a lot with the zero coverage things).[-]shipit_code_coverage: Add a report showing files with zero coverage on a platform but not on another[/-][+]Add a report showing files with zero coverage on a platform but not on another[/+]rv404674 commentedon Sep 24, 2018
Hey @marco-c i can understand the python based code and the frontend part also. But after that, "
then the actual implementation of the platform-difference report generation code and platform-difference frontend code ", i did not understood this.
I am also trying to setup development env, I am following this guide https://docs.mozilla-
releng.net/develop/contribute.html. I have successfully ran these commands.
rahul (master) release-services $ ./please shell codecoverage/bot
OK
rahul (master) release-services $ ./please check codecoverage/bot
DONE
But on this command i am getting the following error.
rahul (master) release-services $ ./please run codecoverage/bot
Error: Application
codecoverage/botis not configured to be runnable.I already have docker and git installed. Can you tell me how to communicate with you using an irc, i am using mobbit but channel #ci ( Mozilla [webirc] is not working. Also can you suggest a better irc.
Thanks.
marco-c commentedon Sep 28, 2018
I meant, after studying that code, then you can go on and start the implementation of the report showing files with zero coverage on a platform but not on another.
Having a shell will be enough, you won't need to run the project.
I've seen you around in #release-services, so I assume you found a solution for this.
pgadige commentedon Oct 25, 2018
I'd like to try to solve this issue.
linux64-ccovorlinux64-jsdcov?Please let me know if I've misinterpreted the workflow of querying zero coverage report on a platform.
marco-c commentedon Oct 25, 2018
We want to produce a report that shows files that have zero coverage on a platform (e.g. Windows) but have coverage > zero on another platform (e.g. Linux).
This will allow us to see files which could be conditionally compiled.
The platforms for now should just be Linux and Windows, we can add Mac later.
kevinluvian commentedon Nov 28, 2018
Hi @marco-c
I added a PR for this issue mozilla/release-services#1713
please take a look when you have time
m-agboola commentedon Jan 7, 2019
@marco-c Is this issue still open? If Yes, I'd like to work on it
marco-c commentedon Jan 7, 2019
mozilla/release-services#1713 was opened by @kevinluvian to fix this. @kevinluvian do you still want to finish it up?
m-agboola commentedon Jan 7, 2019
Yes I'd like to @marco-c
marco-c commentedon Jan 8, 2019
@m-agboola let's wait for @kevinluvian reply first. He's already started working on it.
m-agboola commentedon Jan 8, 2019
Alright @marco-c
kevinluvian commentedon Jan 9, 2019