Skip to content

Add a report showing files with zero coverage on a platform but not on another #23

Open

Description

Activity

  1. rv404674 commented on Sep 22, 2018

    @rv404674
    Contributor

    Hi @marco-c , can i take up this issue.

  2. marco-c commented on Sep 23, 2018

    @marco-c
    CollaboratorAuthor

    Hey @rv404674 , you sure can! This is a pretty involved good first bug though, as it will require understanding of the zero coverage report generation code (https://github.com/mozilla/release-services/blob/master/src/codecoverage/bot/code_coverage_bot/zero_coverage.py), the zero coverage report frontend (https://github.com/marco-c/code-coverage-reports/tree/gh-pages) and then the actual implementation of the platform-difference report generation code and platform-difference frontend code (which will share a lot with the zero coverage things).

  3. changed the title [-]shipit_code_coverage: Add a report showing files with zero coverage on a platform but not on another[/-] [+]Add a report showing files with zero coverage on a platform but not on another[/+] on Sep 23, 2018
  4. rv404674 commented on Sep 24, 2018

    @rv404674
    Contributor

    Hey @marco-c i can understand the python based code and the frontend part also. But after that, "
    then the actual implementation of the platform-difference report generation code and platform-difference frontend code ", i did not understood this.

    I am also trying to setup development env, I am following this guide https://docs.mozilla-
    releng.net/develop/contribute.html. I have successfully ran these commands.

    rahul (master) release-services $ ./please shell codecoverage/bot
    OK

    rahul (master) release-services $ ./please check codecoverage/bot
    DONE

    But on this command i am getting the following error.
    rahul (master) release-services $ ./please run codecoverage/bot
    Error: Application codecoverage/bot is not configured to be runnable.

    I already have docker and git installed. Can you tell me how to communicate with you using an irc, i am using mobbit but channel #ci ( Mozilla [webirc] is not working. Also can you suggest a better irc.
    Thanks.

  5. marco-c commented on Sep 28, 2018

    @marco-c
    CollaboratorAuthor

    Hey @marco-c i can understand the python based code and the frontend part also. But after that, "
    then the actual implementation of the platform-difference report generation code and platform-difference frontend code ", i did not understood this.

    I meant, after studying that code, then you can go on and start the implementation of the report showing files with zero coverage on a platform but not on another.

    But on this command i am getting the following error.
    rahul (master) release-services $ ./please run codecoverage/bot
    Error: Application codecoverage/bot is not configured to be runnable.

    Having a shell will be enough, you won't need to run the project.

    I already have docker and git installed. Can you tell me how to communicate with you using an irc, i am using mobbit but channel #ci ( Mozilla [webirc] is not working. Also can you suggest a better irc.

    I've seen you around in #release-services, so I assume you found a solution for this.

  6. pgadige commented on Oct 25, 2018

    @pgadige

    I'd like to try to solve this issue.

    1. May I know if platform in this context refers to the build platform such as linux64-ccov or linux64-jsdcov?
    2. I suppose the report will be rendered on the front-end when a user selects a specific platform as an option, for instance, if I want to view all zero coverage JavaScript files on a specific platform say P1, I'd select the filers - JavaScript and platform P1
      Please let me know if I've misinterpreted the workflow of querying zero coverage report on a platform.
  7. marco-c commented on Oct 25, 2018

    @marco-c
    CollaboratorAuthor

    We want to produce a report that shows files that have zero coverage on a platform (e.g. Windows) but have coverage > zero on another platform (e.g. Linux).
    This will allow us to see files which could be conditionally compiled.

    The platforms for now should just be Linux and Windows, we can add Mac later.

  8. kevinluvian commented on Nov 28, 2018

    @kevinluvian
    Contributor

    Hi @marco-c
    I added a PR for this issue mozilla/release-services#1713
    please take a look when you have time

  9. m-agboola commented on Jan 7, 2019

    @m-agboola

    @marco-c Is this issue still open? If Yes, I'd like to work on it

  10. marco-c commented on Jan 7, 2019

    @marco-c
    CollaboratorAuthor

    mozilla/release-services#1713 was opened by @kevinluvian to fix this. @kevinluvian do you still want to finish it up?

  11. m-agboola commented on Jan 7, 2019

    @m-agboola

    Yes I'd like to @marco-c

  12. marco-c commented on Jan 8, 2019

    @marco-c
    CollaboratorAuthor

    @m-agboola let's wait for @kevinluvian reply first. He's already started working on it.

  13. m-agboola commented on Jan 8, 2019

    @m-agboola

    Alright @marco-c

  14. kevinluvian commented on Jan 9, 2019

    @kevinluvian
    Contributor
  15. added
    botPython Taskcluster Bot
    on Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    botPython Taskcluster Bot

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions