Repository navigation
Serve the bug-fix broker through a shared run_broker wrapper - #7276
Open
ayoubdiourin7 wants to merge 2 commits into
Open
ayoubdiourin7 wants to merge 2 commits into
ayoubdiourin7 wants to merge 2 commits into
Conversation
suhaibmujahid
requested changes
Oct 28, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
Looks good! Just if we could improve the interface.
|
|
||
|
|
||
| def run_broker[S: BaseSettings]( | ||
| build_app: Callable[[S], ASGIApp], settings_cls: type[S] |
Member
There was a problem hiding this comment.
Can we avoid the requirement to pass settings_cls, it is a bit ugly.
Contributor
Author
There was a problem hiding this comment.
Yes, we can by passing settings_cls into build_app; updated in 0e42e04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7273