Repository navigation
Conversation
The review agent now gives each finding a severity (critical, major, minor or nit), a category and a confidence, guided by a new rubric in the review prompt, and patch-scope comments are always minor. reviewhelper-api stores these fields, summarizes findings by severity in the main comment, and can add them to inline comments as `reviewhelper:` YAML frontmatter behind the `severity_frontmatter_enabled` setting. The `order` and `explanation` the agent already produced are now persisted so comment feedback can be analysed against the agent's ranking and reasoning. The evaluation scorer also reports metrics per severity. Part of mozilla#7195
Member
Author
|
See mozilla-conduit/phabricator#124 for the Phab-side changes. |
# Conflicts: # services/reviewhelper-api/app/review_processor.py
suhaibmujahid
requested changes
Oct 27, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
Thank you! It looks good overall. Some comments regarding the unnecessary columns, I will do the db schema update and deploy to dev.
Member
Author
|
Here's a screenshot from https://phabricator-dev.allizom.org/D4268. I added a commit to change the config knob to be "on" by default, but we can disable via an environment variable if need be. 
|
suhaibmujahid
approved these changes
Oct 29, 2026
suhaibmujahid
left a comment
suhaibmujahid
left a comment
Member
There was a problem hiding this comment.
Looks great! Thank you!
Comment on lines
+326
to
+327
| suggestion.severity = CommentSeverity.MINOR | ||
| suggestion.category = CommentCategory.SCOPE |
Member
There was a problem hiding this comment.
I'm not sure if we need this.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review agent now gives each finding a severity (critical, major, minor or nit), a
category and a confidence, guided by a new rubric in the review prompt, and patch-scope
comments are always minor. reviewhelper-api stores these fields, summarizes findings by
severity in the main comment, and can add them to inline comments as
reviewhelper:YAML frontmatter behind the
severity_frontmatter_enabledsetting. Theorderandexplanationthe agent already produced are now persisted so comment feedback can beanalysed against the agent's ranking and reasoning. The evaluation scorer also reports
metrics per severity.
Part of #7195