Repository navigation
Ensure log formatter doesn't fail with non json-serializable params - #9
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 204 207 +3
Branches 28 28
=====================================
+ Hits 204 207 +3
Continue to review full report at Codecov.
|
|
cc @jezdez on this since he's been working on this project for some time now and could help reviewing this. |
Contributor
|
Yeah I'll check this out asap, just missed it last week while I was away on a work week.
… On 5. Apr 2017, at 18:27, Christopher Grebs ***@***.***> wrote:
cc @jezdez on this since he's been working on this project for some time now and could help reviewing this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Contributor
|
LGTM. |
Contributor
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8
It could be argued that using
o.__dict__instead ofrepr(o)might be better for some users, but I thought it would be too verbose for the generic case. Maybe it would be worth allowing easy customization of the encoder class inJsonLogFormatterinstead, but I went for the simpler patch.