Repository navigation
Make JsonLogFormatter easier to extend - #37
Merged
Merged
Conversation
This was referenced Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #29
Ref mozilla/addons#6761
AMO has switched to Stackdriver, but we're still using python-dockerflow's
JsonLogFormatterto adhere to MozLog standard. We'd like to augment the logs to leverage more Stackdriver functionality, so this is what I came up with to help us. While I was at it I added a separate method to help with mozilla/addons-server#29 because it was a good proof of concept regarding ease of extensibility.Let me know if you consider this is going too far for you - but my alternative is pretty much copy/pasting and modifying this code in our repos...