Repository navigation
Implement bicubic interpolation #74
Description
Currently clip.cpp uses linear interpolation in image preprocessing. The original implementation uses the bicubic interpolation from Pillow. It needs refactoring from Pillow https://github.com/python-pillow/Pillow/blob/main/src/libImaging/Resample.c#L46-L62
Activity
lithdew commentedon Jul 1, 2024
An implementation of bicubic interpolation is available inside llama.cpp.
https://github.com/ggerganov/llama.cpp/blob/master/examples/llava/clip.cpp#L1431
monatis commentedon Jul 1, 2024
Yes, I upstreamed clip.cpp to llama.cpp for LLaVA, and now there's some functionality that needs to be downstreamed from llama.cpp back to this repo. Currently I don't have enough time to maintain it, though. Maybe next month.
lithdew commentedon Jul 1, 2024
I'm looking to use clip.cpp in a project soon - would you mind if I make a PR that brings some of the features in llama.cpp into clip.cpp?
monatis commentedon Jul 1, 2024
@lithdew That would be awesome. And feel free to ping me if you need to ask anything about the implementation.