Skip to content

confusing order of stacked PRs in PR description #41

Closed

Description

@GiorgosAlexakis

Even though the order follows the same pattern as when looking at commits with git log, it may be confusing for reviewers to see stacked PRs in reverse order.

Activity

  1. GiorgosAlexakis commented on Oct 15, 2024

    @GiorgosAlexakis
    Author

    @ZolotukhinM what do you think we should do?

    • Keep as is, prefer limited configuration.
    • Add a configuration option to select the order of the stacked PRs in description.
    • Prefer limited configuration, but switch to 'first to last' ordering.

    I can help by writing code if needed.

  2. ZolotukhinM commented on Oct 17, 2024

    @ZolotukhinM
    Collaborator

    It would be confusing to some people no matter which way we choose, and adding an option can made it even more confusing if one has to review stacks from people with different order settings. So far the design principle we've sticked was to mimic what git does, so I'd say we should stick with the current way and don't change it.

  3. smudge commented on Aug 28, 2025

    @smudge

    It would be confusing to some people no matter which way we choose

    Apologies for chiming in a year later, but it occurred to me that in either case this confusion would be resolved if something visual existed to indicate where main is in the stack.

    Something like:


    Stacked PRs:


    or:


    Stacked PRs:


    WDYT?

  4. ZolotukhinM commented on Nov 16, 2025

    @ZolotukhinM
    Collaborator

    That might be a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions