Repository navigation
Raise the base litestar floor to 2.22 and delete the plugin probe - #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #331.
The base
litestarextra now requires litestar 2.22, up from 2.19. Before, onlylitestar-otlneeded 2.22, forlitestar.plugins.opentelemetry. With the floor raised, that module is always there, so the split and its probe go:pyproject.toml: the base comment gains the 2.22 reason, andlitestar-otlloses its ownlitestar>=2.22line and comment.import_checker.is_litestar_opentelemetry_installedno longer probeslitestar.plugins.opentelemetry. That was one of the dottedfind_speccalls that importlitestarwhenlite_bootstrapis imported (Import bootstrappers lazily from lite_bootstrap/__init__.py #308).Tests
No new test. Nothing behaves differently at the new floor, as the issue says.
One correction to the issue: a test did assert the old message.
test_litestar_otel_is_skipped_without_litestars_opentelemetry_pluginhidlitestar.plugins.opentelemetryand expected a warning matchinglitestar>=2.22. It covered only the probe this deletes, so it is deleted too. The missing-asgi case is still covered bytest_import_checker_survives_incomplete_opentelemetry_namespace.The full suite passes, 556 tests at 100% coverage (
just test-ci).just lint(includingty),just adr-checkandjust docs-buildpass too.I ran the
floorsjob's steps locally for thelitestartarget on 3.11, 3.12, 3.13 and 3.14. CI excludes 3.15 for this target. All four resolve litestar 2.22.0 and passscripts/floor_smoke.py. No other target installs litestar.Breaking changes
A project pinned below litestar 2.22 can't install 2.0. litestar 2.22.0 was released on 2026-05-20.