Skip to content

Raise the base litestar floor to 2.22 and delete the plugin probe - #371

Merged
lesnik512 merged 1 commit into
mainfrom
litestar-floor-2-22
Oct 29, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
litestar-floor-2-22

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Closes #331.

The base litestar extra now requires litestar 2.22, up from 2.19. Before, only litestar-otl needed 2.22, for litestar.plugins.opentelemetry. With the floor raised, that module is always there, so the split and its probe go:

  • pyproject.toml: the base comment gains the 2.22 reason, and litestar-otl loses its own litestar>=2.22 line and comment.
  • import_checker.is_litestar_opentelemetry_installed no longer probes litestar.plugins.opentelemetry. That was one of the dotted find_spec calls that import litestar when lite_bootstrap is imported (Import bootstrappers lazily from lite_bootstrap/__init__.py #308).
  • The Litestar OpenTelemetry instrument's skip message is now "opentelemetry-instrumentation-asgi is not installed".

Tests

No new test. Nothing behaves differently at the new floor, as the issue says.

One correction to the issue: a test did assert the old message. test_litestar_otel_is_skipped_without_litestars_opentelemetry_plugin hid litestar.plugins.opentelemetry and expected a warning matching litestar>=2.22. It covered only the probe this deletes, so it is deleted too. The missing-asgi case is still covered by test_import_checker_survives_incomplete_opentelemetry_namespace.

The full suite passes, 556 tests at 100% coverage (just test-ci). just lint (including ty), just adr-check and just docs-build pass too.

I ran the floors job's steps locally for the litestar target on 3.11, 3.12, 3.13 and 3.14. CI excludes 3.15 for this target. All four resolve litestar 2.22.0 and pass scripts/floor_smoke.py. No other target installs litestar.

Breaking changes

A project pinned below litestar 2.22 can't install 2.0. litestar 2.22.0 was released on 2026-05-20.

@lesnik512 lesnik512 added this to the 2.0.0 milestone Oct 29, 2026
@lesnik512
lesnik512 merged commit 9e35f2c into main Oct 29, 2026
37 checks passed
@lesnik512
lesnik512 deleted the litestar-floor-2-22 branch October 29, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raise the base litestar floor to 2.22 and delete the plugin probe

1 participant