Repository navigation
Raise the OpenTelemetry floor to 1.42 / 0.63b0 and delete its shims - #368
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #315.
The OpenTelemetry extras now require api, sdk and exporters 1.42 and instrumentation 0.63b0, up from 1.28 and 0.49b0. Every
*-otlextra moves together, since each instrumentation package pinsopentelemetry-instrumentationto its own exact version. The new floors let two shims go:OpenTelemetryMiddlewareas a comma-joined string, the way FastAPI already does, and no longer importsparse_excluded_urls. At 0.63b0 the middleware takesExcludeList | str | Noneand parses a string itself (asgi/__init__.py:582,664).PyroscopeSpanProcessor.force_flushis gone. At sdk 1.42.0 the baseSpanProcessor.force_flushreturns True, which is what the override did.I checked both against the v1.42.0 and v0.63b0 sources, and that 0.63b0's
opentelemetry-semantic-conventionspinsopentelemetry-api==1.42.0, so the two floors pair up. Theotlcomment inpyproject.tomlnow explains why the floor is 1.42 rather than 0.49b0'spkg_resourcesreason. ADR 0008 names the new floor.Tests
None are new. As the issue says, no behaviour changes: the existing suite covers both code paths, and the
floorsjob covers the new floors. The deleted override was# pragma: no cover, so coverage stays at 100%.The full suite passes, 551 tests at 100% coverage (
just test-ci).just lint(includingty),just adr-checkandjust docs-buildpass too.I ran the
floorsjob's steps locally for all 23 target and interpreter combinations: five targets on 3.11 to 3.14, and free, fastapi and faststream on 3.15. All 23 resolve opentelemetry-sdk 1.42.0 and opentelemetry-instrumentation 0.63b0 and passscripts/floor_smoke.py.Breaking changes
A project pinned to OpenTelemetry below 1.42 or instrumentation below 0.63b0 can't install 2.0. opentelemetry-sdk 1.42.0 was released on 2026-05-19.