Repository navigation
Honor WebSocket offline model selection with CI (preserves #3887) - #3888
Merged
Merged
Conversation
funasr_wss_server.py parses --asr_model and --asr_model_revision, and the README lists --asr_model, but since #2791 the server built its offline model from a fixed "paraformer-zh" v2.0.4. Both options had no effect, so a server started with another model, such as an English or a fine-tuned one, still ran paraformer-zh. Build the offline model from the two options, as the streaming, VAD and punctuation models are built from theirs. The default of --asr_model becomes "paraformer-zh" (it named the Contextual Paraformer, which the server did not load), so a server started without these options loads the same model as before. Add tests/test_websocket_server_asr_model.py: it runs the server module with AutoModel replaced and checks the model and revision of the offline model, with and without the options.
Preserve the original #3887 fix and contributor ancestry. Add scoped Python 3.10/3.11/3.12 protocol regression CI. Signed-off-by: LauraGPT <zhifu.gzf@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the exact two-file fix from #3887 and its original author commit. Offline WebSocket initialization now honors
--asr_modeland--asr_model_revision; the default remains the model/revision that the server actually used before this fix. Fixes #3886.Add a scoped, read-only Python 3.10/3.11/3.12 workflow for constructor and file-finalization regressions. Previously these changed paths had no matching hosted test workflow. No fork branch rewriting or unrelated model/server changes.
Independently Verified
AutoModel, parsed local configurations, loaded deterministic synthetic state dictionaries and executed CUDA kernels. Five configurations (default plus two model paths/two revisions), ten raw results from two distinct synthetic waveforms; four custom-selection cases fail on baseline and all five pass on the candidate.highest, TF32 disabled, privateNVIDIA_TF32_OVERRIDE=0) resolved that harness mismatch without changing inputs, reference values or tolerance. The original failure and all raw traces remain preserved.This is a source/runtime-script fix, not a new PyPI or production website release.