Repository navigation
docs: link the Version Packages PR to its release issue, not only by comment - #5221
Conversation
…comment The Version Packages PR is linked with addCloseIssueReferences as soon as it is found, carries Part of #N as its body's first line immediately before merging, and keeps the Part of #N comment as the durable record. Closes #5164 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
There was a problem hiding this comment.
🟡 Changes recommended
The body-update recipe can overwrite generated release notes after a failed read unless the edit is guarded.
1 open issue
What changed in this PR
Updates the release documentation and procedure for #5164 so the changesets “Version Packages” PR has a persistent link to its release issue, rather than only a comment.
Changes:
- Require
addCloseIssueReferenceswhen the version PR is found. - Retain the durable
Part of #Ncomment. - Add and verify a
Part of #Nfirst body line immediately before merging.
| File | Description |
|---|---|
RELEASING.md |
Aligns both release-process descriptions with the linking procedure. |
AGENTS.md |
Updates the Version Packages exception to require the link and pre-merge body line. |
.claude/skills/release/SKILL.md |
Adds linking, body-editing, and pre-merge verification steps. |
Review effort: Balanced
… read A failed gh pr view must not let gh pr edit replace the generated release notes with the Part of prefix alone (Copilot, #5221). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: cliffhall <cliff@futurescale.com>
|
Copilot round 1: one finding.
Requesting round 2. |
There was a problem hiding this comment.
🟢 Approval recommended
The changes consistently implement #5164, address the prior body-update safeguard feedback, and leave no unresolved blocking issues.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
|
Copilot round 2: clean ("No open issues"; the round-1 finding is marked resolved). The review loop stops on this first clean round. |
…on-packages-link Signed-off-by: cliffhall <cliff@futurescale.com> # Conflicts: # RELEASING.md

Closes #5164
Description
The changesets "Version Packages" PR was tied to its milestone's release issue by a
Part of #Ncomment only. A comment is not a link: the PR showed no linked issue and the release issue listed nothing (v2.0.0's #5100 was linked to #5159 by hand after it merged). This brings it in line with every other PR, adjusted for the action rewriting its body:addCloseIssueReferencesas soon as the PR is found. The link lives outside the body, so the rewrites on each push tov2/maindon't remove it, and onv2/mainit closes nothing at merge.Part of #Nbecomes the body's first line immediately before merging, after the last regeneration, and is checked to still be there at merge (repeat if a push regenerated the body).Part of #Ncomment stays as the durable textual record.Changed together:
AGENTS.md: the rule (Contributing → Exception: the two version PRs that automation opens)..claude/skills/release/SKILL.mdstep 2b: the recipe (link + comment in step 1; the new steps 4 and 5 prepend the line and check it before the merge).RELEASING.md: its two descriptions of how the Version Packages PR references the release issue (per the maintenance rule on versioning/publishing docs).docs/agent-guidance-inception.mdis left alone: it's the historical inception record.Server Details
None (repository-wide): docs and the
releaseskill only.Motivation and Context
See #5164.
How Has This Been Tested?
No client-observable surface, so I ran targeted probes of the new recipe, read-only, against v2.0.0's Version Packages PR #5100 (release issue #5159):
/pr-flow:gh pr view 5100 --json closingIssuesReferences --jq '[.closingIssuesReferences[].number]'→[5159].gh pr view 5100 --json body --jq '.body | split("\n")[0]'→Part of #5159.Part of #5159, then a blank line, then the original body intact (47 → 49 lines).npm run local:gateexits 0 under Node 24.22.1 (the development version). On Node 26.7.0 it fails in one memory test,persistence.test.ts› reports a graph file that cannot be read as a tool error. That failure is already tracked in #5162, comes fromv2/main, and this Markdown-only diff doesn't touch it. Every other stage passed on 26.7 too.Breaking Changes
None.
Types of changes
Checklist
npm run changeset) if this changes what a TypeScript server publishes (not applicable: publishes nothing)🤖 Generated with Claude Code