Repository navigation
[Server] Announce listChanged for a custom registry wired to the notification bus - #608
Merged
chr-hertel merged 1 commit intoOct 18, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 18, 2026 13:14
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves existing defaults and the bus requirement, with relevant tests and no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds an explicit opt-in for custom registries that publish changes, addressing #607 while preserving #593’s safeguards.
Changes:
- Adds
setRegistry(..., publishesChanges: true), retaining the notification-bus requirement. - Tests custom-registry capability announcements with and without a bus.
- Documents the opt-in and updates the changelog.
| File | Description |
|---|---|
| tests/Unit/Server/BuilderTest.php | Tests opt-in behavior and the bus requirement. |
| src/Server/Builder.php | Adds the opt-in to capability detection. |
| docs/run/subscriptions.md | Shows custom-registry wiring and opt-in usage. |
| docs/run/server-builder.md | Documents the new parameter. |
| CHANGELOG.md | Records expanded custom-registry support. |
Review effort: Balanced
chr-hertel
changed the title
listChanged for a custom registry that publishes its changeslistChanged for a custom registry wired to the notification bus
chr-hertel
force-pushed
the
issue-607-listchanged-is-not-announced-for
branch
from
October 18, 2026 13:33
1264be4 to
f8d8fbc
Compare
chr-hertel
force-pushed
the
issue-607-listchanged-is-not-announced-for
branch
from
October 18, 2026 13:43
f8d8fbc to
6232c69
Compare
chr-hertel
added
breaking change
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #593, which was too strict: a registry passed via
setRegistry()can be wired to the bus by the caller, as symfony/mcp-bundle does, but never gotlistChangedannounced => no list-change notifications on 2026-07-28 for bundle users.Instead of a flag on
setRegistry(), the registry says so itself viaRegistryInterface::publishesListChanges():Registryreturnstruewhen its dispatcher is aPublishingEventDispatcher. No change needed in the bundle.[BC Break] for other implementations - the ones I found are decorators (api-platform's
SecureRegistry, EC-CUBE'sScopeFilteringRegistry) and just forward to the inner registry. On the interface rather than a separate one, so a decorated registry doesn't silently lose the announcement.Fixes #607