Repository navigation
[Server] Point a refused gateway request at InputRequiredResult - #606
Merged
chr-hertel merged 2 commits intoOct 18, 2026
Merged
chr-hertel merged 2 commits into
chr-hertel merged 2 commits into
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 18, 2026 13:04
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused guidance correction matches existing SDK APIs and includes regression assertions, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Corrects stateless gateway refusal guidance to point handlers to the SDK’s existing input-resolution flow.
Changes:
- Names the refused request and recommends
InputRequiredResultandRequestContext::getInputContext(). - Adds assertions checking the request name and replacement guidance.
| File | Description |
|---|---|
| tests/Unit/Server/Stateless/StatelessProtocolTest.php | Verifies the updated refusal message. |
| src/Server/Stateless/StatelessProtocol.php | Corrects the exception message and explanatory comment. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 2026-07-28 a handler calling
ClientGateway::sample()orlistRoots()is told that sampling and roots "were removed" and to take what it needs through tool arguments instead. That's not what the SDK does tho -InputRequiredResultcarries both, the client'sInputRequestResolveranswers them andInputContexthassamplingResult()/rootsResult(). The 0.9.0 changelog says the same.The message now names the request and points at
InputRequiredResult.Ran into it with symfony/mcp-bundle's demo app, which took the message at face value and stopped testing sampling & roots on 2026-07-28.