Repository navigation
[Client] Mark the client disconnected when the stdio server exits - #573
Merged
chr-hertel merged 1 commit intoOct 12, 2026
Merged
chr-hertel merged 1 commit into
chr-hertel merged 1 commit into
Conversation
chr-hertel
added
bug
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused state-management fix is consistent with existing client behavior and has appropriate regression coverage.
0 open findings
What changed in this PR
Marks clients disconnected after stdio server output closes or writes fail.
Changes:
- Invalidates client state on stdio connection loss.
- Adds unit and integration regression coverage.
- Documents the corrected behavior.
| File | Description |
|---|---|
src/Client/Transport/StdioTransport.php |
Invalidates state on connection loss. |
tests/Unit/Client/Transport/StdioTransportTest.php |
Tests both failure paths. |
tests/Integration/DeadServerTest.php |
Verifies client behavior after server exit. |
tests/Integration/Fixture/dead_server.php |
Provides the terminating server fixture. |
CHANGELOG.md |
Records the fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
chr-hertel
force-pushed
the
fix-client-stdio-dead-server
branch
from
October 12, 2026 20:56
a93f3a7 to
d1dc9e8
Compare
chr-hertel
force-pushed
the
fix-client-stdio-dead-server
branch
from
October 12, 2026 23:07
d1dc9e8 to
27ea33f
Compare
chr-hertel
added a commit
to chr-hertel/mcp-test
that referenced
this pull request
Oct 18, 2026
A spawned server that exited before answering used to surface as "no longer running" after the init timeout, and the connection went on claiming to be connected. The SDK's client now reports the exit code and the end of stderr, fails at once, and marks itself disconnected (modelcontextprotocol/php-sdk#573 and the stderr reporting next to it). `dead_stdio` on the `minimal` client prints a reason and exits with 3; the test asserts that both reach the bundle's ConnectionException, in well under the 5 s timeout, and that isConnected() is false afterwards. The regression command never iterates `minimal`, so the dead server stays out of every suite run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #547 a call to an exited stdio server fails at once, but
isConnected()stays true and later calls go against the dead process.StdioTransportmarks the client uninitialized when the server closes its output or can no longer be written tostate->setInitialized(false)), so the two compose - [Client] Invalidate expired HTTP sessions #560 covers the HTTP side ([Client] A lost HTTP session leaves the client connected chr-hertel/php-sdk#66)Fixes chr-hertel#71
🤖 Generated with Claude Code