Repository navigation
[Client] Throw TimeoutException on request timeout and cancel the request - #567
Merged
chr-hertel merged 1 commit intoOct 12, 2026
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 10, 2026 01:53
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The changelog does not disclose the public pending-request timestamp type compatibility change.
1 open finding
What changed in this PR
Improves request-timeout precision and surfaces timeouts consistently as cancellable TimeoutExceptions.
Changes:
- Uses microsecond-resolution timestamps.
- Applies default timeouts as deadlines and sends cancellation signals.
- Updates exception inheritance, tests, documentation, and changelog.
| File | Description |
|---|---|
src/Client.php |
Applies the configured timeout as a deadline. |
src/Client/State/ClientState.php |
Stores precise request timestamps. |
src/Client/State/ClientStateInterface.php |
Updates the pending-request timestamp type. |
src/Client/Transport/HttpTransport.php |
Uses precise timeout comparisons. |
src/Client/Transport/StdioTransport.php |
Uses precise timeout comparisons. |
src/Exception/TimeoutException.php |
Makes timeouts request exceptions. |
tests/Integration/CancellationTest.php |
Tests default timeout timing and cancellation. |
docs/client/errors.md |
Documents timeout handling. |
docs/client/transports.md |
Documents timeout cancellation behavior. |
CHANGELOG.md |
Records the timeout fix. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…uest The default request timeout now runs as a sub-second deadline like the per-call one.
chr-hertel
force-pushed
the
fix-client-request-timeout
branch
from
October 12, 2026 23:19
2bcda5a to
986032d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The default request timeout used `time()`, so it fired up to a second early, and it surfaced as a generic `RequestException` (-32603) without telling the server.
Fixes chr-hertel#68
Fixes chr-hertel#69
🤖 Generated with Claude Code