Repository navigation
Duo hardening: a game to the end, a matrix that can fail, the server going away - #2
Merged
Merged
Conversation
…going away - duo-matrix.sh fails unless the game passes with no bug on and each bug fails it at the step that should catch it; it only printed before. - A new server bug, match-hands-over, so step 3's "A plays again" can fail. - duo-play.sh plays seed 42 to a draw at 4 each, and resets with a mismatch held up for 3s (/reset?hide=3s): at the game's 0.8s the Quest missed the face-up pair three runs in three. - duo-outage.sh runs its own server on 8788, stops it mid-game and starts it again. The app now clears "did not answer" once the server answers, and a refusal once the board changes; before, the message stayed. Passes on the Android 15 emulator and the Meta Spatial Simulator in both orders; the outage needs Mobium's quoted deep link (CHALLENGES 369).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening the two-player game's tests, and covering what they skipped.
duo-matrix.shcan fail. It printed each run's exit and always exited 0. It now fails unless the game passes with no bug on and each bug fails it at the step that should catch it:out-of-turnat 2,match-hands-overat 3,score-swapat 3,turn-stuckat 4. With one expected step wrong on purpose it exits 1.match-hands-over, with its Go test, so step 3's "A plays again" can come back red. It does, at step 3./reset?hide=3s; a reset without it gives the game's 0.8 back). At 0.8 s the Quest missed the face-up pair three runs in three.duo-play.shplays seed 42 to a 4–4 draw, including a second mismatch that hands the turn back, and reads the draw line on both screens.duo-outage.shruns its own server on 8788, stops it mid-game and starts it again. Both devices must say it did not answer, keep the last board, refuse a flip as unanswered, then drop the message and show the server's new game. The app needed a fix: it cleared neither "did not answer" nor a stale refusal; it now clears the first when the server answers and the second when the board changes. The app as onmainfails step 4.Measured on the Android 15 emulator and the Meta Spatial Simulator, each device as A in turn:
duo-play.sh,duo-matrix.sh(4 of 4) andduo-outage.shpass, andduo.shstill passes;go testpasses.The outage test needs mobiumdev/mobium#288 (merged): before it,
mobium opencut a deep link at its&, soserver=never arrived and every duo device played on the default:8787.The README's duo video still shows the earlier five-move game.