Skip to content

[security] Reject executable YAML in benchmark configurations - #192

Open
TeoSlayer wants to merge 2 commits into
mlcommons:masterfrom
TeoSlayer:fix/safe-runner-yaml
Open

TeoSlayer wants to merge 2 commits into
mlcommons:masterfrom
TeoSlayer:fix/safe-runner-yaml

Conversation

@TeoSlayer

@TeoSlayer TeoSlayer commented Nov 9, 2026 •

Copy link
Copy Markdown

Security fix: supplied device and test-script YAML can execute Python with the benchmark runner’s permissions. Replace unsafe object construction in all three configuration inputs. This also fixes inline device configuration on modern PyYAML.

Validation: three unittest cases passed, covering inline/file equivalence, shipped scripts, and rejection of executable tags. Parsing tests require no hardware drivers.

The new secret-free CI workflow runs these regressions on Python 3.10 and 3.12; both jobs and the CLA check now pass. Sparse checkout avoids unrelated benchmark assets.

@TeoSlayer
TeoSlayer requested a review from a team as a code owner November 9, 2026 17:59
@TeoSlayer TeoSlayer changed the title Parse runner YAML with safe loaders [security] Reject executable YAML in benchmark configurations Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant