Skip to content

Keep a thread's settings when its data is saved; show choices by title - #485

Merged
wmobley merged 1 commit into
developfrom
fix/thread-keeps-settings
Nov 20, 2026
Merged

wmobley merged 1 commit into
developfrom
fix/thread-keeps-settings

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Found while testing the flow settings on dev.

Settings lost on a Datasets save. UpdateThreadData, the mutation the Datasets step saves with, deleted every thread_model_parameter row in the thread. Any settings a runner had chosen, and values carried over to a new flow, disappeared whenever data was assigned again, so it looked as if "the defaults don't stay". The values do not depend on the data bound, so the mutation now keeps them. It still clears what the data replaces: model inputs, runs and run summaries. Deleting a problem statement, task or thread still removes them.

Choice titles in the read-only view. After saving, the settings table showed the stored value (longest_match). It now shows the choice's title ("Longest term wins"), falling back to the value.

Checks: ui-react 162 files / 1665 tests pass (new tests: the mutation keeps parameter values; choiceText); tsc -b clean; prettier clean; eslint 0 errors.

🤖 Generated with Claude Code

…title

Saving the Datasets step deleted every parameter value in the thread, so the
settings a runner had chosen were lost whenever data was assigned again. The
values do not depend on the data; the step still clears what the data
replaces (model inputs, runs and their summaries).

The read-only settings view now shows a choice's title (Longest term wins)
instead of its stored value (longest_match).
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 9:23pm UTC

@wmobley
wmobley merged commit 3a4a7eb into develop Nov 20, 2026
42 checks passed

This branch was successfully deployed

1 active deployment
Preview — 29f43b25 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant