Repository navigation
Keep a thread's settings when its data is saved; show choices by title - #485
Merged
Merged
Conversation
…title Saving the Datasets step deleted every parameter value in the thread, so the settings a runner had chosen were lost whenever data was assigned again. The values do not depend on the data; the step still clears what the data replaces (model inputs, runs and their summaries). The read-only settings view now shows a choice's title (Longest term wins) instead of its stored value (longest_match).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the flow settings on dev.
Settings lost on a Datasets save.
UpdateThreadData, the mutation the Datasets step saves with, deleted everythread_model_parameterrow in the thread. Any settings a runner had chosen, and values carried over to a new flow, disappeared whenever data was assigned again, so it looked as if "the defaults don't stay". The values do not depend on the data bound, so the mutation now keeps them. It still clears what the data replaces: model inputs, runs and run summaries. Deleting a problem statement, task or thread still removes them.Choice titles in the read-only view. After saving, the settings table showed the stored value (
longest_match). It now shows the choice's title ("Longest term wins"), falling back to the value.Checks: ui-react 162 files / 1665 tests pass (new tests: the mutation keeps parameter values;
choiceText);tsc -bclean; prettier clean; eslint 0 errors.🤖 Generated with Claude Code