Skip to content

Load the model tree for upload suggestions before a variable is chosen - #483

Merged
wmobley merged 1 commit into
developfrom
fix/upload-ranking-loads-models
Nov 20, 2026
Merged

wmobley merged 1 commit into
developfrom
fix/upload-ranking-loads-models

Conversation

@wmobley

@wmobley wmobley commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Found while testing #482 on dev: every upload suggestion read "No registered flow or model takes this as an input" and kept the plain semantic order, so document_collection__text was not ranked first for the RGV transcript text.

Cause: DatasetUploadPage queried the model tree with skip: !variable, so the tree that ranks the suggestions was not loaded until a variable was picked. The page test's mock of the tree hook ignored skip, which hid it.

Fix: the tree loads as soon as there is text to suggest from (or a variable is chosen). The mock now honours skip, and a new page test checks the ranking and the "who uses this" text before any variable is chosen; it fails on the old code.

Checks: ui-react 162 files / 1663 tests pass; tsc -b clean; prettier and eslint clean on the changed files.

🤖 Generated with Claude Code

The suggestion ranking needs the model tree, but the page only queried it
once a variable was picked, so every suggestion read as unused and kept the
semantic order. The tree now loads as soon as there is text to suggest from.
The page test's tree mock honours skip like the real hook.
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
monorepo Ready Ready Preview Nov 20, 2026 8:31pm UTC

@wmobley
wmobley merged commit 6bfec5f into develop Nov 20, 2026
42 checks passed

This branch was successfully deployed

1 active deployment
Preview — 94fea204 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant