Repository navigation
Load the model tree for upload suggestions before a variable is chosen - #483
Merged
Merged
Conversation
The suggestion ranking needs the model tree, but the page only queried it once a variable was picked, so every suggestion read as unused and kept the semantic order. The tree now loads as soon as there is text to suggest from. The page test's tree mock honours skip like the real hook.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing #482 on dev: every upload suggestion read "No registered flow or model takes this as an input" and kept the plain semantic order, so
document_collection__textwas not ranked first for the RGV transcript text.Cause:
DatasetUploadPagequeried the model tree withskip: !variable, so the tree that ranks the suggestions was not loaded until a variable was picked. The page test's mock of the tree hook ignoredskip, which hid it.Fix: the tree loads as soon as there is text to suggest from (or a variable is chosen). The mock now honours
skip, and a new page test checks the ranking and the "who uses this" text before any variable is chosen; it fails on the old code.Checks: ui-react 162 files / 1663 tests pass;
tsc -bclean; prettier and eslint clean on the changed files.🤖 Generated with Claude Code