Repository navigation
Conversation
Add modelcatalog_configuration_flow.settings_json (visibility and fixed per
setting) and expose it to the same roles as thread_bindings_json. The adapter
passes a piece's setting description (title, choices, bounds, advanced) through
its piece summary and plan parameters, resolves each setting for a runner
(GET /flows/{id}/settings), checks hidden and fixed settings have a value, and
refuses a runner's value for a fixed or hidden setting at submit. The catalog
API writes the settings and mirrors defaults, fixed values, choices and bounds
onto the flow's parameter rows, and relays the settings read.
…x, hide or default them Add a shared setting input (dropdown with the chosen choice's explanation, bounded number box, checkbox, text). Each setting in a step card now shows the piece's title and explanation and lets the author choose a default or a fixed value and whether it is shown, advanced or hidden. The choices are saved as the flow's settings and sent to the check.
…el multi-select
A flow's settings show the piece's title and explanation, with a dropdown for
choices, a bounded number box and a checkbox, filled with the flow's default.
Advanced settings sit in a collapsed section, hidden ones are not shown, and
fixed ones are listed read-only. A value left at the default is not bound, so the
author's defaults are still accepted at run. A model parameter with accepted values
is a multi-select, and several values are several runs. Settings are read through
the catalog API's new GET /flows/{id}/settings, falling back to the parameter rows.
…s, conflicts Compare refused runner values trimmed, without case and through aliases. The flow check now refuses values for credential-like setting names, a thread-filled setting that is also fixed or hidden, and pieces that describe a shared setting two ways; the hidden message names the setting and step. A model multi-select keeps values that are not accepted, flagged. The builder says hidden is not secret. Tests and docs updated.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Combined into #482 so all five build and deploy together. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design spec:
docs/design/2026-11-20-flow-setting-schemas.md(Approved; implementation deviations recorded).What it does
app.jsonarguments: titles, dropdowns whose choices are each explained (oneOfconst/title/description), number inputs with bounds, defaults pre-filled, advanced settings collapsed, hidden settings omitted, fixed ones read-only. Model parameters withhas_accepted_valuesbecome a multi-select (several values still mean several runs).modelcatalog_configuration_flow.settings_json(migration1771300000047, insert-only likethread_bindings_json); the catalog API'sPOST /flowsmirrors default, fixed, accepted values, bounds and type onto the flow parameter rows._piece_summarypasses the new schema keys; newGET /flows/{id}/settings(relayed by the catalog API like/availability); one resolver for plan, submit and the route. Precedence: fixed > runner > author default > piece default.FLOW_SETTING_REFUSEDfor runner values on fixed or hidden settings (names compared trimmed, case-insensitive, through aliases). Flow check:FLOW_SETTING_HIDDEN_WITHOUT_VALUE,FLOW_SETTING_FIXED_WITHOUT_VALUE,FLOW_SETTING_INVALID,FLOW_SETTING_CONFLICT,FLOW_SETTING_LOOKS_SECRET(no author values on credential-like names),FLOW_THREAD_BINDING_FIXED. The accept-the-author's-settings dialog lists every author value, hidden and fixed included.settings_json = {}) render and run as before.Reviews
QA and security reviews ran on the diff; all findings were fixed in
499b4c3(no high-severity security findings).Tests
test_demo_apifailures (git-ignored.env).test_flow_settings.py: 45 tests.tsc --noEmitclean.tsc -b, prettier clean; eslint 0 errors.text[]write, a browser run.Rollout
Apply the migration and metadata before the new code. Library pieces with the new schemas are on
wmobley/Semantic-Sensemakingfeat/setting-schemas(stacked on upstream PR #3); registering them and re-registering the Sensemaking flows is a separate dev step.Do not merge until dev testing is scheduled.
🤖 Generated with Claude Code